[NP] Migrate saved object mappings and migration scripts for Dashboard #63864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
added
v8.0.0
release_note:skip
6 tasks
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
LGTM for platform changes.
Referencing #63943 as I will have to integrate these changes
| @@ -230,6 +230,7 @@ export { | |||
| SavedObjectsMigrationLogger, | |||
| SavedObjectsRawDoc, | |||
| SavedObjectSanitizedDoc, | |||
| SavedObjectUnsanitizedDoc, | |||
There was a problem hiding this comment.
@rudolf I'm going to stop fighting against this export. It's a parameter type of a public core API anyway.
flash1293
approved these changes
Apr 22, 2020
maryia-lapata
added a commit
that referenced
this pull request
Apr 23, 2020
#63864) (#64194) * Migrate saved objects * Move common used types and fucntions to dashboard/common * Fix unit tests * Update server.api.md * Fix TS * Update i18n IDs * Update TS Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
maryia-lapata
added
backported
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #61259.
Move the
dashboardsaved object type registration from the legacy world to Kibana platform.