[NP] Vega migration #63849
Merged
[NP] Vega migration #63849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-lapata
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@maryia-lapata Could you try whether this fix solves your problem: #63886 ? Thanks @mistic! |
@flash1293, unfortunately, it didn't help. I've got the same issue: |
|
@maryia-lapata Just tested and it seems to work. As this is in a package, you have to run Then it fails because |
69 tasks
|
I still have a warning, but everything seems to work fine. But unfortunately this warning fails CI. |
|
Looking up what this means I'm pretty sure it's caused by this part of the vega code: ['canvas', 'canvas-prebuilt'].some(function(libName) {
try {
NodeCanvas = require(libName);
if (typeof NodeCanvas !== 'function') {
NodeCanvas = null;
}
} catch (error) {
NodeCanvas = null;
}
return NodeCanvas;
});@mistic Not sure whether it's the right approach but can we ignore the warning in this specific instance? As vega is only running in the client, we don't need the |
|
@elasticmachine merge upstream |
flash1293
reviewed
Apr 22, 2020
|
@elasticmachine merge upstream |
|
It looks like webpack does not consider safe to do that kind of imports on browser code. The current version of vega we are using ends up in a deprecated and try to just exclude only those 2 warnings for now? Do you have any other idea here? |
|
It might be too hacky, but for this specific case https://www.npmjs.com/package/webpack-plugin-replace could be an option to just strip out this require statement completely because we don't need it for the plugin to function. |
|
Just pushed a new commit that skips parsing for |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 24, 2020
mistic
approved these changes
Apr 24, 2020
maryia-lapata
added a commit
that referenced
this pull request
Apr 24, 2020
* Vega migartion * Move mocha tests to legacy * Fix TS * Update .i18nrc.json * Move mocks to vis_type_vega * Fix issue with babel and vega deps * Update mocha test * Mock services * Update vega_request_handler.ts * don't parse vega-lib/build/vega.js Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: spalger <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 27, 2020
…bana into ingest-node-pipeline/open-flyout-create-edit * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits) [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411) Report Deletion via UI- functional test (elastic#64031) Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402) [Uptime] Update TLS settings (elastic#64111) [alerting] removes usage of any throughout Alerting Services code (elastic#64161) [CANVAS] Moves notify to a canvas service (elastic#63268) [Canvas] Misc NP Stuff (elastic#63703) update apm index pattern (elastic#64232) Task/hostlist pagination (elastic#63722) [NP] Vega migration (elastic#63849) Move ensureDefaultIndexPattern into data plugin (elastic#63100) [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106) Migrate graph_workspace saved object registration to Kibana platform (elastic#64157) Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184) [ML] EuiDataGrid ml/transform components. (elastic#63447) [ML] Moving to kibana capabilities (elastic#64057) Move input_control_vis into NP (elastic#63333) remove reference to local application service in graph (elastic#64288) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #60097.
The
Vegaplugin migration to new platform.