[Uptime] Certificate expiration threshold settings #63682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Right now the dropdowns for these day fields only have one option, is there a way to make them have >1 option? Seems strange that they'd be a select field if you can only choose one thing.
Overall this looks really good and appears to work fine for me locally.
| /> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem grow={1}> | ||
| <EuiSelect options={[{ value: 'day', text: 'Days' }]} /> |
There was a problem hiding this comment.
Do we want more options here besides day? If not we may not want to use a Select here.
| const settingsBreadcrumbText = i18n.translate('xpack.uptime.settingsBreadcrumbText', { | ||
| defaultMessage: 'Settings', | ||
| }); | ||
| useBreadcrumbs([{ text: settingsBreadcrumbText }]); | ||
|
|
||
| useUptimeTelemetry(UptimePage.Settings); | ||
|
|
||
| const dispatch = useDispatch(); |
There was a problem hiding this comment.
++ on cleaning this up
| /> | ||
| </EuiFormRow> | ||
| </EuiDescribedFormGroup> | ||
| <IndicesForm |
| certificatesThresholds: { | ||
| properties: { | ||
| errorState: { | ||
| type: 'long', |
There was a problem hiding this comment.
Kind of nit but long might not be necessary. Effectively an unimportant observation though as we're only going to have one of these objects per space.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (40 commits) [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723) add deprecation warning for legacy 3rd party plugins (elastic#62401) Migrate timelion vis (elastic#62819) Replacebad scope link with actual values (elastic#63444) Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111) [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207) [Maps] fix term join agg key collision (elastic#63324) [Ingest] Fix agent config key sorting (elastic#63488) [Monitoring] Fixed server response errors (elastic#63181) update elastic charts to 18.3.0 (elastic#63732) Start services (elastic#63720) [APM] Encode spaces when creating ML job (elastic#63683) Uptime 7.7 docs (elastic#62228) [DOCS] Updates remote cluster and ccr docs (elastic#63517) [Maps] Add 3rd party vector tile support (elastic#62084) [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016) [Endpoint] Host Details Policy Response Panel (elastic#63518) [Uptime] Certificate expiration threshold settings (elastic#63682) Refactor saved object types to use `namespaceType` (elastic#63217) [SIEM][CASE] Create comments sequentially (elastic#63692) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Apr 20, 2020
* update settings * added cert form * update settings * update types * update test * updated tests * updated snapshots
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
shahzad31
added a commit
that referenced
this pull request
Apr 22, 2020
* [Uptime] Certificate expiration threshold settings (#63682) * update settings * added cert form * update settings * update types * update test * updated tests * updated snapshots * up snapshots Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
shahzad31
added a commit
that referenced
this pull request
Apr 23, 2020
* [Uptime] Certificate expiration threshold settings (#63682) * update settings * added cert form * update settings * update types * update test * updated tests * updated snapshots * [Uptime] Refresh index and also show more info to user regardi… (#62606) * Refresh index and also show more info to user * updated type * updated type * updated test * updated formatting * update text * updated types * updated translation * update * fixed types * updated code * fixed types Co-authored-by: Elastic Machine <[email protected]> * updated snapshots * up snapshots * update trans Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #63681
Added Certificate State Threshold settings