-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics Regression exploration: replace table with data grid #63650
Merged
alvarezmelissa87
merged 11 commits into
elastic:master
from
alvarezmelissa87:ml-dfanalytics-regression-results-datagrid
Apr 16, 2020
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dc1ee6f
add feature_importance column correctly
alvarezmelissa87 5fd8887
wip: switch regression table to datagrid
alvarezmelissa87 bd90784
add search bar to regression view
alvarezmelissa87 a8a1399
ensure feature importance fields show up correctly
alvarezmelissa87 93c3754
wip: filter by training/testing
alvarezmelissa87 10a1a99
remove separate testing/training filter
alvarezmelissa87 c95df27
make error more clear
alvarezmelissa87 0d66d71
handle lucene queries
alvarezmelissa87 4f834cc
remove unnecessary comment
alvarezmelissa87 e825faa
ensure boolean shows up correctly.no sorting by feature importance
alvarezmelissa87 0a8fc7a
remove unused translations
alvarezmelissa87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this change, can you explain why having the individual fields is no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
feature_importance
field is an array of objects so the<results_field>.feature_importance.<id>
field name wasn't actually mapping to anything - that column was just empty.Setting it as just
feature_importance
lets the whole array show up in the popup.