Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Fixed issue when connectors dropdown not showing all avaliable connectors #63636

Merged
merged 1 commit into from
Apr 16, 2020
Merged

[Alerting] Fixed issue when connectors dropdown not showing all avaliable connectors #63636

merged 1 commit into from
Apr 16, 2020

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Apr 15, 2020 •
edited
Loading

Summary

Current PR is resolving the issue #63390, where empty list of connectors was displayed not depend of the number of connectors exists.

After:
img1

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.7.1 labels Apr 15, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner April 15, 2020 19:04
@YulNaumenko YulNaumenko self-assigned this Apr 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

pmuellr
pmuellr approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected with multiple pre-configured actions

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko linked an issue Apr 15, 2020 that may be closed by this pull request
[Alerting] Connectors dropdown not showing all available connectors #63390
Closed
@mikecote mikecote self-requested a review April 16, 2020 13:07
mikecote
mikecote approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM!

@YulNaumenko YulNaumenko merged commit 560e01a into elastic:master Apr 16, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Apr 16, 2020
@YulNaumenko
[Alerting] Fixed issue when connectors dropdown not showing all avail…
7130365 
…able connectors (elastic#63636)
@YulNaumenko YulNaumenko mentioned this pull request Apr 16, 2020
Merged
YulNaumenko added a commit that referenced this pull request Apr 16, 2020
@YulNaumenko
[Alerting] Fixed issue when connectors dropdown not showing all avail…
22c045f 
…able connectors (#63636) (#63718)
@mikecote mikecote mentioned this pull request Apr 17, 2020
Closed
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request May 14, 2020
@YulNaumenko
[Alerting] Fixed issue when connectors dropdown not showing all avail…
7d64087 
…able connectors (elastic#63636)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.test.tsx
@YulNaumenko YulNaumenko mentioned this pull request May 14, 2020
Merged
YulNaumenko added a commit that referenced this pull request May 15, 2020
@YulNaumenko
[7.7] [Alerting] Fixed issue when connectors dropdown not showing all…
04da18e 
… available connectors (#63636) (#66600)

* [Alerting] Fixed issue when connectors dropdown not showing all available connectors (#63636)

# Conflicts:
#	x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.test.tsx

* Fixed merge issue

* Fixed failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Connectors dropdown not showing all available connectors
5 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @mikecote