Added server api tests for event log service #63540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
…functional-tests # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…functional-tests # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mikecote
approved these changes
Apr 16, 2020
x-pack/test/plugin_api_integration/test_suites/event_log/service_api_integration.ts
Outdated
Show resolved
Hide resolved
x-pack/test/plugin_api_integration/test_suites/event_log/service_api_integration.ts
Outdated
Show resolved
Hide resolved
x-pack/test/plugin_api_integration/test_suites/event_log/service_api_integration.ts
Outdated
Show resolved
Hide resolved
pmuellr
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
This is looking pretty good! I made a note about not needing the start/stop timing - I think - but doing a test of those slightly differently. There are a number of logger.info()'s which I assume will get cleaned up before merge.
I'm a little worried about flakiness, given the async nature of the logger, suggest we run this through the flaky test runner. In the future, when we buffer events instead of just writing them individually in async fashion, things will get even flakier - but we'll worry about that when we get there.
x-pack/test/plugin_api_integration/plugins/event_log/server/init_routes.ts
Show resolved
Hide resolved
x-pack/test/plugin_api_integration/plugins/event_log/server/init_routes.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 17, 2020
* Added server api tests for event log service * fixed tests * fixed type check issue * Fixed failing tests * fixed jest tests * Fixed due to comments * Removed flackiness tests * fixed type check error * Fixed func test
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Apr 17, 2020
* Added server api tests for event log service * fixed tests * fixed type check issue * Fixed failing tests * fixed jest tests * Fixed due to comments * Removed flackiness tests * fixed type check error * Fixed func test
YulNaumenko
added a commit
that referenced
this pull request
Apr 18, 2020
* Added server api tests for event log service (#63540) * Added server api tests for event log service * fixed tests * fixed type check issue * Fixed failing tests * fixed jest tests * Fixed due to comments * Removed flackiness tests * fixed type check error * Fixed func test * fixed compatibility issues * fixed type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #55642