[SIEM] [Detection Engine] Changes find_statuses route HTTP method from GET to POST #63508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
|
Update the script of: x-pack/legacy/plugins/siem/server/lib/detection_engine/scripts/find_rules_statuses_by_ids.shOptional but adding a backend e2e test for this would be really helpful to just at least test that this endpoint responds with a 200. For bodies and stuff to be consistent you can still test them but might have to post the rule as "enabled: false" first. At least one backend test would be a really nice complement but optional at this point since there's unit tests. |
FrankHassanabad
approved these changes
Apr 14, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
Apr 16, 2020
…tic#63508) * changes http method for find_statuses route from GET to POST * fix test string formatting * update sample shell script for find statuses route * adds e2e test for find statuses
dhurley14
added a commit
to dhurley14/kibana
that referenced
this pull request
May 19, 2020
…tic#63508) * changes http method for find_statuses route from GET to POST * fix test string formatting * update sample shell script for find statuses route * adds e2e test for find statuses
dhurley14
added a commit
that referenced
this pull request
May 20, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #63481 . The URL query string was growing too large after around 200-ish rule ids and hapi could not parse that many items, so we changed the http method from GET to POST with a body.
Checklist
Delete any items that are not applicable to this PR.
For maintainers