New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sub-menus to Resolver node (for 75% zoom) #63476

Merged

bkimmel merged 13 commits into elastic:master from bkimmel:resolver/add-node-submenus

Apr 20, 2020

Contributor

bkimmel commented Apr 14, 2020 •

edited

Loading

Summary

This PR adds submenus to resolver nodes to match the 75% zoom level. It adds a FlexGroup to manage alignment/gutters for the submenu buttons.

of note:

Added EUI button utility classes ( https://github.com/elastic/kibana/pull/63476/files#diff-b18117271821fdd985eed1e1c4fd749fR332 ) to achieve look/features of EUI button while using palette in design comps ( https://github.com/elastic/kibana/pull/63476/files#diff-e528a0d2a347e46e873de1face92b8f1R77 )
Added 2 EUI buttons to match current design comps for 75% view of nodes ( https://github.com/elastic/kibana/pull/63476/files#diff-b18117271821fdd985eed1e1c4fd749fR354 )
Added a background fill to the text elements area to prevent other elements from appearing behind (per design review)

Screenshots

Mocks

These are mocks for reference only
NOT SCREENSHOTS

NOT SCREENSHOTS

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
(https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

kqualters-elastic and others added 11 commits

April 13, 2020 12:02


          Update cli mapping to match endpoint package

c109f55


          Update alert mapping to match

14ef3cf


          BACK OUT: changes to make kibana run

0985e14


          adding two buttons for 75% zoom view

b759ea6


          change to extra-small gutters

6222b00


          adjusting styles so boxes lay out and scale correctly

208ed98


          adjust palette to match comps

dbc8714


          tabindex and style adjustments

35c2bf5


          L. Poli Review: buttons should be type small in 25% view

374296d


          i18n

4245a82


          width adjustment to match mocks

5abadc9

bkimmel marked this pull request as ready for review

April 16, 2020 21:52

bkimmel requested a review from a team as a code owner

April 16, 2020 21:52

lindseypoli approved these changes

View reviewed changes

jonathan-buttner reviewed

View reviewed changes

x-pack/plugins/endpoint/scripts/resolver_generator.ts

    
            @@ -29,7 +29,7 @@ async function main() {
          
                  alertIndex: {

                    alias: 'ai',

                    describe: 'index to store alerts in',

                    default: '.alerts-endpoint-000001',

                    default: 'events-endpoint-1',

Contributor

jonathan-buttner Apr 17, 2020

@bkimmel I agree that we should probably keep this as events-endpoint-1 since that's what the app is looking for in master.

@elastic/endpoint-response are you ok with this?

x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx Outdated

                   descriptionFill: NamedColors.empty,
                   descriptionText: i18n.translate('xpack.endpoint.resolver.terminatedTrigger', {
                     defaultMessage: 'Terminated Trigger',
                   }),
                 },
               };
+              const ChildEventsButton = () => {

Contributor

jonathan-buttner Apr 17, 2020

Not sure if it's useful but should we add the data-test-subj to any of these buttons? @achuguy @IgorGuz2000

Contributor

oatkiller Apr 17, 2020

we should add data-test-subj attributes in the PR where they are used.

x-pack/plugins/endpoint/scripts/alert_mapping.json Outdated Show resolved Hide resolved

oatkiller reviewed

View reviewed changes

x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx Show resolved Hide resolved

oatkiller reviewed

View reviewed changes

x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx Outdated

+              const RelatedAlertsButton = () => {
+                return (
+                  <EuiButton
+                    onClick={(clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {

Contributor

oatkiller Apr 17, 2020 •

edited

Loading

can you wrap the functions in useCallback, this way EuiButton will get the same function reference each time RelatedAlertsButton is rendered, and EuiButton won't necessarily have to rerender just because its parent did.

<EuiButton
  onClick={useCallback((clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
    clickEvent.preventDefault();
    clickEvent.stopPropagation();
  }, [])}

oatkiller reviewed

View reviewed changes

x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx Outdated

+              const ChildEventsButton = () => {
+                return (
+                  <EuiButton
+                    onClick={(clickEvent: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {

Contributor

oatkiller Apr 17, 2020

same thing as below, but could you wrap the function in useCallback

oatkiller reviewed

View reviewed changes

x-pack/plugins/endpoint/public/embeddables/resolver/view/process_event_dot.tsx Outdated

                   descriptionFill: NamedColors.empty,
                   descriptionText: i18n.translate('xpack.endpoint.resolver.terminatedTrigger', {
                     defaultMessage: 'Terminated Trigger',
                   }),
                 },
               };
+              const ChildEventsButton = () => {

Contributor

oatkiller Apr 17, 2020

you can wrap these new components in
React.memo if ya want:

https://reactjs.org/docs/react-api.html#reactmemo

oatkiller suggested changes

View reviewed changes

Contributor

oatkiller left a comment

:+1 but could you add React.memo and useCallback in a few places. This code will run on every frame after all.

Brent Kimmel added 2 commits

April 20, 2020 09:59


          R. Austin Review: Add memo and useCallback

e2de763


          Merge remote-tracking branch 'upstream/master' into resolver/add-node…

ed4f4fb

…-submenus

bkimmel added Feature:Endpoint Feature:Resolver v8.0.0 labels

Contributor

elasticmachine commented Apr 20, 2020

Pinging @elastic/endpoint-app-team (Feature:Resolver)

bkimmel added the release_note:skip label

Contributor Author

bkimmel commented Apr 20, 2020

:+1 but could you add React.memo and useCallback in a few places. This code will run on every frame after all.

@oatkiller e2de763

Contributor

kibanamachine commented Apr 20, 2020

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ed4f4fb

History

💚 Build #41406 succeeded 5abadc9
💔 Build #41395 failed 374296d
💚 Build #41086 succeeded 35c2bf5
💚 Build #40828 succeeded dbc8714
💚 Build #40802 succeeded 208ed98

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

oatkiller approved these changes

View reviewed changes

jonathan-buttner approved these changes

View reviewed changes

bkimmel merged commit 5b11434 into elastic:master

bkimmel deleted the resolver/add-node-submenus branch

April 20, 2020 20:28

bkimmel mentioned this pull request

[7.x] Add sub-menus to Resolver node (for 75% zoom) (#63476) #64005

Merged

gmmorris added a commit to gmmorris/kibana that referenced this pull request


          Merge branch 'master' into actions/pagerduty-date-format

baab614

* master: (30 commits)
  Migrate vis_type_table to kibana/new platform  (elastic#63105)
  Enable include/exclude in Terms agg for numeric fields (elastic#59425)
  follow conventions for saved object definitions (elastic#63571)
  [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935)
  kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838)
  Fix page layouts, clean up unused code (elastic#63992)
  [SIEM] Adds recursive exact key checks for validation and formatter
  [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859)
  [Maps] Do not fetch geo_shape from docvalues (elastic#63997)
  Vega doc changes (elastic#63889)
  [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049)
  Add sub-menus to Resolver node (for 75% zoom) (elastic#63476)
  [FTR] Add test suite metrics tracking/output (elastic#62515)
  [ML] Fixing single metric viewer page padding (elastic#63839)
  [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623)
  [Reporting] Config flag to escape formula CSV values (elastic#63645)
  [Metrics UI] Remove remaining field filtering (elastic#63398)
  [Maps] fix date labels (elastic#63909)
  [TSVB] Use default Kibana palette for split series (elastic#62241)
  Ingest overview page (elastic#63214)
  ...

jloleysens added a commit that referenced this pull request


          Merge branch 'master' of github.com:elastic/kibana into feature/inges…

2c340b2

…t-node-pipelines

* 'master' of github.com:elastic/kibana: (32 commits)
  Move authz lib out of snapshot restore (#63947)
  Migrate vis_type_table to kibana/new platform  (#63105)
  Enable include/exclude in Terms agg for numeric fields (#59425)
  follow conventions for saved object definitions (#63571)
  [Docs]Adds saved object key setting to load balancing kib instances (#63935)
  kbn/config-schema: Consider maybe properties as optional keys in ObjectType (#63838)
  Fix page layouts, clean up unused code (#63992)
  [SIEM] Adds recursive exact key checks for validation and formatter
  [Maps] Migrate remaining maps client files to NP (except routi… (#63859)
  [Maps] Do not fetch geo_shape from docvalues (#63997)
  Vega doc changes (#63889)
  [Metrics UI] Reorganize file layout for Metrics UI (#60049)
  Add sub-menus to Resolver node (for 75% zoom) (#63476)
  [FTR] Add test suite metrics tracking/output (#62515)
  [ML] Fixing single metric viewer page padding (#63839)
  [Discover] Allow user to generate a report after saving a modified saved search (#63623)
  [Reporting] Config flag to escape formula CSV values (#63645)
  [Metrics UI] Remove remaining field filtering (#63398)
  [Maps] fix date labels (#63909)
  [TSVB] Use default Kibana palette for split series (#62241)
  ...

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…

07fdb89

…bana into ingest-node-pipelines/privileges

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits)
  Move authz lib out of snapshot restore (elastic#63947)
  Migrate vis_type_table to kibana/new platform  (elastic#63105)
  Enable include/exclude in Terms agg for numeric fields (elastic#59425)
  follow conventions for saved object definitions (elastic#63571)
  [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935)
  kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838)
  Fix page layouts, clean up unused code (elastic#63992)
  [SIEM] Adds recursive exact key checks for validation and formatter
  [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859)
  [Maps] Do not fetch geo_shape from docvalues (elastic#63997)
  Vega doc changes (elastic#63889)
  [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049)
  Add sub-menus to Resolver node (for 75% zoom) (elastic#63476)
  [FTR] Add test suite metrics tracking/output (elastic#62515)
  [Ingest pipelines] Delete pipeline (elastic#63635)
  [ML] Fixing single metric viewer page padding (elastic#63839)
  [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623)
  [Reporting] Config flag to escape formula CSV values (elastic#63645)
  [Metrics UI] Remove remaining field filtering (elastic#63398)
  [Maps] fix date labels (elastic#63909)
  ...

# Conflicts:
#	x-pack/legacy/plugins/uptime/public/components/monitor/ml/index.ts
#	x-pack/legacy/plugins/uptime/public/components/overview/index.ts
#	x-pack/plugins/ingest_pipelines/public/application/index.tsx
#	x-pack/plugins/ingest_pipelines/server/routes/api/index.ts
#	x-pack/plugins/ingest_pipelines/server/routes/index.ts

bkimmel added a commit that referenced this pull request


          Add sub-menus to Resolver node (for 75% zoom) (#63476) (#64005)

be181d4

* adding two buttons for 75% zoom view
* adjust palette to match comps
Co-authored-by: Kevin Qualters <[email protected]>

jloleysens added a commit to jloleysens/kibana that referenced this pull request


          Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…

29b006b

…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (34 commits)
  [Ingest Node Pipelines] Clone Pipeline (elastic#64049)
  Move authz lib out of snapshot restore (elastic#63947)
  Migrate vis_type_table to kibana/new platform  (elastic#63105)
  Enable include/exclude in Terms agg for numeric fields (elastic#59425)
  follow conventions for saved object definitions (elastic#63571)
  [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935)
  kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838)
  Fix page layouts, clean up unused code (elastic#63992)
  [SIEM] Adds recursive exact key checks for validation and formatter
  [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859)
  [Maps] Do not fetch geo_shape from docvalues (elastic#63997)
  Vega doc changes (elastic#63889)
  [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049)
  Add sub-menus to Resolver node (for 75% zoom) (elastic#63476)
  [FTR] Add test suite metrics tracking/output (elastic#62515)
  [Ingest pipelines] Delete pipeline (elastic#63635)
  [ML] Fixing single metric viewer page padding (elastic#63839)
  [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623)
  [Reporting] Config flag to escape formula CSV values (elastic#63645)
  [Metrics UI] Remove remaining field filtering (elastic#63398)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Endpoint Feature:Resolver release_note:skip v8.0.0