[7.x] Endpoint: Move files, add README, replace implicit any with stricter types. Reorganize types. (#63262)
#63363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r types. Reorganize types. (elastic#63262) * Removed `FIXME` comments and references to private repos. Please use Github issues to track work * Added a README describing the modules in `applications/endpoint` * Removed dead code * Moved `AppRoot` component to its own module * Moved `applications/endpoint/services` under `store` * Moved some exported types to `applications/endpoint/types` * Moved all React code to `view` * Added types in some places that were implicitly `any` * Moved `PageId` type from common directory (where it could be shared with the server) to the public directory Conflicts: * `x-pack/plugins/endpoint/public/applications/endpoint/view/policy/policy_details.tsx`
oatkiller
commented
Apr 13, 2020
| @@ -30,7 +30,7 @@ import { | |||
| apiError, | |||
| } from '../../store/policy_details/selectors'; | |||
| import { WindowsEventing } from './policy_forms/eventing/windows'; | |||
| import { PageView, PageViewHeaderTitle } from '../../components/page_view'; | |||
| import { PageView, PageViewHeaderTitle } from '../components/page_view'; | |||
There was a problem hiding this comment.
@parkiino conflict was here. I think you removed WindowsEventing in master but not in 7.x
There was a problem hiding this comment.
oh i still need to do my backport osrry
💚 Build SucceededTo update your PR or re-run it, just comment with: |
peluja1012
approved these changes
Apr 13, 2020
james-elastic
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
anywith stricter types. Reorganize types. (Move files, add README, replace implicitanywith stricter types. Reorganize types. #63262)