-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest overview page #63214
Merged
Merged
Ingest overview page #63214
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3ddd775
use fixed table layout
ee9e0d3
Merge remote-tracking branch 'upstream/master'
01e5b24
Merge remote-tracking branch 'upstream/master'
547661e
added markup structure / css for overview page
e158aae
add flyout and links to other pages
e11741c
add "alpha" messaging at bottom of all pages
93eabf0
Merge remote-tracking branch 'upstream/master' into ingest-overview-page
30ae899
attrs instead of defaultProps on styled components
49be45b
use FormattedMessage on alpha messaging component
ac44be3
Merge remote-tracking branch 'upstream/master' into ingest-overview-page
431b8a4
remove leftover code
1719c35
Merge remote-tracking branch 'upstream/master' into ingest-overview-page
e24269e
remove unused import
c5710fa
Merge remote-tracking branch 'upstream/master' into ingest-overview-page
08d8fd2
Merge remote-tracking branch 'upstream/master' into ingest-overview-page
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
.../plugins/ingest_manager/public/applications/ingest_manager/components/alpha_messaging.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
import React from 'react'; | ||
import styled from 'styled-components'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
import { EuiText } from '@elastic/eui'; | ||
|
||
const Message = styled(EuiText).attrs(props => ({ | ||
color: 'subdued', | ||
textAlign: 'center', | ||
}))` | ||
padding: ${props => props.theme.eui.paddingSizes.m}; | ||
`; | ||
|
||
export const AlphaMessaging: React.FC<{}> = () => ( | ||
<Message> | ||
<p> | ||
<small> | ||
<strong> | ||
<FormattedMessage | ||
id="xpack.ingestManager.alphaMessageTitle" | ||
defaultMessage="Alpha release" | ||
/> | ||
</strong> | ||
{' – '} | ||
<FormattedMessage | ||
id="xpack.ingestManager.alphaMessageDescription" | ||
defaultMessage="Ingest Manager is under active development and is not | ||
intended for production purposes." | ||
/> | ||
</small> | ||
</p> | ||
</Message> | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the flex properties here, as well as in
with_header
andwithout_header
layouts in #63992.The flex properties were breaking other pages, causing them not to expand to full width. It didn't seem like the removal affected the overview page contents or the alpha messaging so hopefully it's good to go. For future reference if a page content needs flex, the individual pages should wrap its contents in EuiFlexGroup or similar. The base layouts will rarely need adjusting :)