Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Endpoint][EPM] Retrieve Index Pattern from Ingest Manager #63016
[Endpoint][EPM] Retrieve Index Pattern from Ingest Manager #63016
Changes from all commits
b69c2ad
7c7eaee
c9f0507
b82762b
cb45dfe
9e4f6e3
8cbfa42
a1f2bd0
f13231a
0c9946d
0140395
6c7b7b4
745c15d
661f860
b839152
cf1a071
9ff1e7b
8272634
3599f46
6c22146
6457c0f
3fd2dc1
4d2e8ce
e94629f
89dd822
337ab45
9ced2c8
4dc5854
b669294
cc4a355
1aa9388
dd033d4
efdcc2d
2829689
6facd1f
ec0a649
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind adding a quick doc comment to public methods? maybe
I think these types of comments will help a lot, esp. considering the size of the org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should (can?) any of these call be cached?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I haven't created an issue for it yet but we'll create a cache so we don't have to do so many calls to the saved objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: https://github.com/elastic/endpoint-app-team/issues/340