-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TSVB] Fix wrongly display stacked as percentage charts #62654
[TSVB] Fix wrongly display stacked as percentage charts #62654
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
ACK, reviewing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome Linux with given sample data. Fixes the issue. Code LGTM
I think the new behavior looks more appropriate to me, and also should match what we're doing in visualize editor in percentage mode. If we want to stick more closely to the previous behavior I think we could use |
Good suggestion @timroes - changing the interpolation mode for all TSVB visualizations seems like a confusing change for people used to the old behavior. Just a nit though, IMHO we can also address this later (and give the user control over interpolation while we are at it). |
@flash1293 @timroes I will push another change in the elastic-chart to fix this behavior. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared deps upgrade LGTM
Update to elastic-charts 18.2.2 with the valid 0% rendering
Update to elastic-charts 18.2.2 with the valid 0% rendering
Approving retroactively, tested and the new behavior looks good to me 👍 Sorry for the delay |
Summary
This PR fix an issue with stack as percentage charts in TSVB by upgrading the
@elastic/charts
library to18.2.2
the patch version that solves this issue: elastic/elastic-charts#617Fix #62419
In this fix, when rendering a stacked area chart in percentage mode, if we have all values as 0 in a bucket, the chart will render a 0% data point for all the series.
Only in case where the values are nulls it will completely disconnect the line/area points where we found the not defined value.
@elastic/charts upgrade procedure