Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] View signal in default timeline #62616

Merged
merged 5 commits into from
Apr 6, 2020
Merged

[SIEM] View signal in default timeline #62616

merged 5 commits into from
Apr 6, 2020

Conversation

MadameSheema
Copy link
Member

Summary

In this PR we are adding a new test in order to check that a signal can be opened in the default timeline.

detections_timeline spec ts

In order to perform the test:

  1. Loads a set of data with es_archiver that has a rule with default timeline and signals
  2. Goes to "Detections page"
  3. Expands the first signal in order to save the id
  4. Clicks in view signal in timeline
  5. Checks that the id of the signal displayed in the timeline is the correct one.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 6, 2020
@MadameSheema MadameSheema requested a review from a team as a code owner April 6, 2020 13:51
@MadameSheema MadameSheema self-assigned this Apr 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

yctercero
yctercero approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only thing I might change (up to you) is that the language changed from 'View signal in timeline' to 'Investigate signal in timeline' so maybe the language in the tests can be changed to use 'investigate' as well?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 813d6cb into elastic:master Apr 6, 2020
@MadameSheema MadameSheema deleted the view-signal-timeline branch April 6, 2020 19:42
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Apr 6, 2020
@MadameSheema
[SIEM] View signal in default timeline (elastic#62616)
bba57fa 
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
@MadameSheema MadameSheema mentioned this pull request Apr 6, 2020
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Apr 6, 2020
@MadameSheema
[SIEM] View signal in default timeline (elastic#62616)
cc73ec1 
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
@MadameSheema MadameSheema mentioned this pull request Apr 6, 2020
Merged
MadameSheema added a commit that referenced this pull request Apr 7, 2020
@MadameSheema
[SIEM] View signal in default timeline (#62616) (#62689)
d44699e 
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
MadameSheema added a commit that referenced this pull request Apr 7, 2020
@MadameSheema
[SIEM] View signal in default timeline (#62616) (#62690)
0e16f5b 
* adds test data

* adds 'View a signal in timeline' test

* implements test

* fixes implementation

* changes view signal for investigate signal
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

@rylnd rylnd Awaiting requested review from rylnd

@dhurley14 dhurley14 Awaiting requested review from dhurley14

@FrankHassanabad FrankHassanabad Awaiting requested review from FrankHassanabad

@spong spong Awaiting requested review from spong

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @yctercero @MindyRS