Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Register ML and Transforms for the kibana home page #62499

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 3, 2020

Registering ML and Transforms so they appear on the kibana home page.

image

It's worth noting that currently Transforms does not have its own icon and so I have used the management app's generic cog icon.

Fixes #62478

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 3, 2020 18:48
@jgowdyelastic jgowdyelastic self-assigned this Apr 3, 2020
@jgowdyelastic jgowdyelastic added :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v7.8.0 v8.0.0 labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic force-pushed the register-ml-for-the-kibana-home-page branch from 62d7e53 to 773ba85 Compare April 3, 2020 18:54
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 4, 2020 08:20
@jgowdyelastic jgowdyelastic changed the title [ML] Register ML for the kibana home page [ML] Register ML and Transforms for the kibana home page Apr 4, 2020
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test locally.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 4386d5f into elastic:master Apr 6, 2020
@jgowdyelastic jgowdyelastic deleted the register-ml-for-the-kibana-home-page branch April 6, 2020 12:50
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Apr 6, 2020
* [ML] Register ML for the kibana home page

* adds transforms

* tiny refactor

* updating comments

Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Apr 6, 2020
* [ML] Register ML for the kibana home page

* adds transforms

* tiny refactor

* updating comments

Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit that referenced this pull request Apr 6, 2020
…2602)

* [ML] Register ML for the kibana home page

* adds transforms

* tiny refactor

* updating comments

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit that referenced this pull request Apr 6, 2020
…2603)

* [ML] Register ML for the kibana home page

* adds transforms

* tiny refactor

* updating comments

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: File upload link missing from homepage
6 participants