[SIEM] Ensure rule message do not span multiple lines #62391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because these messages are used for logging, we should ensure they do not span multiple lines and confuse log parsers. Since the frontend does not currently display these newlines, anyway, there is no impact to the UI.
rylnd
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
rylnd
changed the title
💚 Build SucceededTo update your PR or re-run it, just comment with: |
dhurley14
approved these changes
Apr 3, 2020
This was referenced Apr 3, 2020
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Apr 3, 2020
Because these messages are used for logging, we should ensure they do not span multiple lines and confuse log parsers. Since the frontend does not currently display these newlines, anyway, there is no impact to the UI.
rylnd
added a commit
that referenced
this pull request
Apr 3, 2020
rylnd
added a commit
that referenced
this pull request
Apr 3, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because these messages are used for logging, we should ensure they do
not span multiple lines and confuse log parsers. Since the frontend does
not currently display these newlines, anyway, there is no impact to the
UI.
Checklist
For maintainers