Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest semver because of AMD related bug #6237

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Feb 12, 2016

A fix for my semver version problem in #6236 (but not a fix for the underlying problem mentioned in that issue).

@epixa epixa added the review label Feb 12, 2016
@epixa
Copy link
Contributor

epixa commented Feb 25, 2016

jenkins, test it

@epixa epixa self-assigned this Feb 25, 2016
@epixa
Copy link
Contributor

epixa commented Feb 25, 2016

Since 5.0.0 of semver removed support for AMD, is this safe to upgrade in 4.x?

@epixa epixa added the v5.0.0 label Feb 25, 2016
@kimjoar
Copy link
Contributor Author

kimjoar commented Feb 26, 2016

Hm, as we use webpack for 4.x I don't think it's a problem. No problem for me if we push this to v5 only.

epixa added a commit that referenced this pull request Feb 26, 2016
Upgrade to latest semver because of AMD related bug
@epixa epixa merged commit 1a7f2a6 into elastic:master Feb 26, 2016
@kimjoar kimjoar deleted the semver-5.1.0 branch February 26, 2016 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants