Vislib: Fix position calculation of ticks in non-horizontal axes #62309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Vislib
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@markov00 down for a last round of |
|
@elasticmachine merge upstream |
majagrubic
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
It wasn't immediately obvious to me what this change is about. Tested with the following scenarios:
- created vertical bar chart on sample data logs
- y-axis is sum of bytes
- x-axis date range on
@timstampfield
Positioning of x-axis: - x-axis is bottom
- x-axis is left
- x-axis is right
All works as expected. Tested on Mac OS in Chrome 80.
Great for adding a functional test as well 👍 ✅
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
markov00
approved these changes
Apr 6, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Apr 6, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Apr 6, 2020
flash1293
added a commit
that referenced
this pull request
Apr 6, 2020
flash1293
added a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21589
This PR fixes the hopefully last instance of the problem discovered here: #62004 (review):
Most of this was already cleaned up with this PR: #47563
But it didn't take one case into account:
If
Filter labelsis enabled, the very first label of the vertical axis is always filtered out, even if there is enough space.This happens because the calculation of the current tick position didn't correctly take the scale padding into account for vertical scales - it was always added even though it has to be subtracted in this case because vertical scales are inverted.
This PR includes a functional test for this specific case and fixes the existing one for the general case (it confused x and y axis).