Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics Alerts] Fix action variables, default message, and EUI casing #62061

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Mar 31, 2020

Summary

Fixes #62025
Fixes #62029
Fixes #61519
Fixes #62043

The bulk of this PR is in reporting all needed action variables to the metric alert's context, including those values in the dropdown menu, and setting a default alert message communicating how to use them.

Because value/metric/threshold can all wildly differ when the user has multiple conditions defined, these variables are now reported in a dynamic record with the naming convention condition{n}.

Screen Shot 2020-03-31 at 2 32 05 PM

Also fixes a minor EUI casing bug and alert title bug.

Checklist

Delete any items that are not applicable to this PR.

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 31, 2020
@Zacqary Zacqary requested a review from a team as a code owner March 31, 2020 19:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 1e47cb2 into elastic:master Apr 1, 2020
@Zacqary Zacqary deleted the 62025-action-variables branch April 1, 2020 16:57
Zacqary added a commit to Zacqary/kibana that referenced this pull request Apr 1, 2020
…tic#62061)

* [Metrics Alerts] Fix action variables, default message, and EUI casing

* i18nize action variables
Zacqary added a commit to Zacqary/kibana that referenced this pull request Apr 1, 2020
…tic#62061)

* [Metrics Alerts] Fix action variables, default message, and EUI casing

* i18nize action variables
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0
Projects
None yet
4 participants