Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing job ID in edit job flyout #61840

Merged
merged 3 commits into from
Mar 31, 2020
Merged

[ML] Fixing job ID in edit job flyout #61840

merged 3 commits into from
Mar 31, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Mar 30, 2020 •
edited
Loading

Fixes #55094

image

@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 30, 2020 15:53
@jgowdyelastic jgowdyelastic self-assigned this Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

walterra
walterra approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 0033e04 into elastic:master Mar 31, 2020
@jgowdyelastic jgowdyelastic deleted the fixing-job-id-in-edit-flyout branch March 31, 2020 09:10
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 31, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 31, 2020
@jgowdyelastic @elasticmachine
[ML] Fixing job ID in edit job flyout (elastic#61840)
dfaafb2 
Co-authored-by: Elastic Machine <[email protected]>
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 31, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 31, 2020
@jgowdyelastic @elasticmachine
[ML] Fixing job ID in edit job flyout (elastic#61840)
a55f7be 
Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit that referenced this pull request Mar 31, 2020
@jgowdyelastic @elasticmachine
[ML] Fixing job ID in edit job flyout (#61840) (#61943)
cf81604 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit that referenced this pull request Mar 31, 2020
@jgowdyelastic @elasticmachine
[ML] Fixing job ID in edit job flyout (#61840) (#61944)
e142bce 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Unclear which anomaly detection job is being edited
6 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @alvarezmelissa87 @peteharverson