optimizer - allow out-of-band plugins #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
changed the title
| loaderPostfixes: ['-loader', ''], | ||
| root: fromRoot('.'), | ||
| alias: this.env.aliases, | ||
| unsafeCache: this.unsafeCache, | ||
| }, | ||
|
|
||
| resolveLoader: { |
There was a problem hiding this comment.
how is this added function called?
There was a problem hiding this comment.
it's just a part of webpack config http://webpack.github.io/docs/configuration.html#resolveloader
|
Looks like somethinig is choking if we have a |
…portPluginsAnywhere
without this, plugins outside of the kibana code base will need to install the babel-runtime.
|
yep, @tsullivan, having a .babelrc file in your plugin will cause issues unless it's designed to work with babel 5. That said, we're working on removing obstacles that were being overcome with babel/gulp and ideally we will be able to drop the .babelrc files and just use kibana's babel |
|
LGTM |
spalger
added a commit
that referenced
this pull request
Feb 12, 2016
optimizer - allow out-of-band plugins
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently plugins need to live within the Kibana source tree in order to build properly. This shouldn't be necessary, but how to accomplish this was previously unclear. Some experimentation this morning lead to a solution that seems to work great.
Now plugins can be added by simply specifying their path via the command line: