-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Cluster state watch to Kibana alerting #61685
[Monitoring] Cluster state watch to Kibana alerting #61685
Conversation
Pinging @elastic/stack-monitoring (Team:Monitoring) |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
} | ||
} | ||
|
||
if (alerts.total !== 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should this maybe be if (alerts.total > 1) {
? Since it can still be a different falsy value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good 🥇
The i18n tests started failing once this was merged, so I've reverted it for now: https://kibana-ci.elastic.co/job/elastic+kibana+master/4238/execution/node/148/log/
|
* master: (36 commits) [data.search.aggs] Remove service getters from agg types (elastic#61628) fixing APM internationalization (elastic#62757) fix: 🐛 correctly create error on no_matching_indices (elastic#61257) [Lens] Remove all legacy imports (elastic#62596) Add label for ace editor (elastic#62588) [ML] Show better file structure finder explanations (elastic#62316) Fix old pathes in eslintrc (elastic#62580) [Uptime] Improve Telemetry test (elastic#62428) [SIEM] Adds sort rules Cypress test (elastic#62700) [Uptime]Abstracted 'access:uptime-read' tag into a wrapper for… (elastic#62576) fixing bug (elastic#62577) [Maps] Allow updating requestType for ESGeoGridSource (elastic#62365) [Maps] do not show circle border when symbol size is zero (elastic#62644) [Maps] Always show current zoom level (elastic#62684) bc5 siem rules merge (elastic#62679) Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)" Fix visual tests (elastic#62660) [Telemetry] update crypto packages (elastic#62469) [DOCS] Removed references to left (elastic#60807) [Maps] Move layers to np maps (elastic#61877) ...
…ng (elastic#62793) * Revert "Revert "[Monitoring] Cluster state watch to Kibana alerting (elastic#61685)"" This reverts commit f1bd3bd. * Fix i18n error * Fix test
Builds upon #54306
Relates to #42960
This PR migrates the next cluster alert, the cluster state one.
Most of the changes in the PR are due to the initial work not working that well for multiple alerts, so some refactoring was necessary.
In particular, the way in which we tell the client what to show in the alert in the UI changed. The original implementation didn't support what we needed to do with other alerts so that's been changed and hopefully makes sense. It's a bit of a "generic" approach and I am welcome to any better approaches here.
Testing
KIBANA_ALERTING_ENABLED
totrue
in bothlegacy/plugins/monitoring/common/constants.js
andplugins/monitoring/common/constants.ts
Screenshots
Creation
Post creation
TODO