Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] DF Analytics: ensure job state is up to date #61678

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Mar 27, 2020

Summary

Related issue #58596

Removes job state from url and instead fetches it on results view load to ensure it is always up to date.

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #36894 succeeded 192ba0406d00c65bcbe056d1022b735014987777

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 9bf6336 into elastic:master Mar 30, 2020
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 30, 2020
* classification results: fetch job state on load

* regression results: fetch job state on load

* outlier results: fetch job state on load

* remove deprecated code adding jobStatus to url

* update outlier result test
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 30, 2020
* classification results: fetch job state on load

* regression results: fetch job state on load

* outlier results: fetch job state on load

* remove deprecated code adding jobStatus to url

* update outlier result test
@alvarezmelissa87 alvarezmelissa87 deleted the ml-df-analytics-badge branch March 30, 2020 17:19
alvarezmelissa87 added a commit that referenced this pull request Mar 30, 2020
* classification results: fetch job state on load

* regression results: fetch job state on load

* outlier results: fetch job state on load

* remove deprecated code adding jobStatus to url

* update outlier result test
jgowdyelastic pushed a commit that referenced this pull request Mar 31, 2020
* classification results: fetch job state on load

* regression results: fetch job state on load

* outlier results: fetch job state on load

* remove deprecated code adding jobStatus to url

* update outlier result test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants