-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics: ensure job state is up to date #61678
Merged
alvarezmelissa87
merged 5 commits into
elastic:master
from
alvarezmelissa87:ml-df-analytics-badge
Mar 30, 2020
Merged
[ML] DF Analytics: ensure job state is up to date #61678
alvarezmelissa87
merged 5 commits into
elastic:master
from
alvarezmelissa87:ml-df-analytics-badge
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:fix
:ml
v8.0.0
Feature:Data Frame Analytics
ML data frame analytics features
v7.7.0
labels
Mar 27, 2020
alvarezmelissa87
requested review from
walterra,
peteharverson and
jgowdyelastic
March 27, 2020 18:11
Pinging @elastic/ml-ui (:ml) |
walterra
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
peteharverson
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
alvarezmelissa87
force-pushed
the
ml-df-analytics-badge
branch
from
March 30, 2020 13:49
192ba04
to
0f620b1
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Mar 30, 2020
* classification results: fetch job state on load * regression results: fetch job state on load * outlier results: fetch job state on load * remove deprecated code adding jobStatus to url * update outlier result test
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Mar 30, 2020
* classification results: fetch job state on load * regression results: fetch job state on load * outlier results: fetch job state on load * remove deprecated code adding jobStatus to url * update outlier result test
alvarezmelissa87
added a commit
that referenced
this pull request
Mar 30, 2020
jgowdyelastic
pushed a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue #58596
Removes job state from url and instead fetches it on results view load to ensure it is always up to date.
Checklist
Delete any items that are not applicable to this PR.