[Search service] Temporarily remove wait_for_completion async param #61677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
review
Feature:Search
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
Failure is known flaky: #61690 |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
I am unable to reproduce the failure locally. If we hit that same error the tests should be skipped. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@elastic/kibana-app-arch merging without a codeowner review since this needs to unblock the ES snapshots. |
This was referenced Mar 30, 2020
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 30, 2020
Co-authored-by: Elastic Machine <[email protected]>
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Mar 30, 2020
Co-authored-by: Elastic Machine <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Mar 30, 2020
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Lukas Olson <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Mar 30, 2020
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Lukas Olson <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related: #61641
Since Elasticsearch renamed the
wait_for_completionparameter, but we can't update the snapshots while there is a broken build, this PR provides an interim step toward #61641 which removes the parameter completely and instead uses a poll interval. Once this passes CI we can update the snapshots and once again start using the correct parameter name.Checklist
Delete any items that are not applicable to this PR.
For maintainers