[alerting] change eventLog schema to use dynamic false #61633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuellr
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
resolves elastic#58518 Changes the object properties in the eventLog mappings to use `dynamic: false` instead of `dynamic: strict`. This provides a bit of a safety net for cases where the mappings change during development, or potentially in production cases. Rather than completely lose entire events and see errors in logs, we'll silently drop properties from events. While researching the `dynamic` property, I remember there's also a `meta` property available, which is a convenient place to drop our meta-data about a field being an array value, for internal processing. Bonus, it can live in the generated mappings as well. references: - https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-field-meta.html - https://www.elastic.co/guide/en/elasticsearch/reference/current/dynamic.html
pmuellr
force-pushed
the
eventLog/dynamic-false
branch
from
90094a2 to
81f33b7
Compare
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 27, 2020
resolves elastic#58518 Changes the object properties in the eventLog mappings to use `dynamic: false` instead of `dynamic: strict`. This provides a bit of a safety net for cases where the mappings change during development, or potentially in production cases. Rather than completely lose entire events and see errors in logs, we'll silently drop properties from events. While researching the `dynamic` property, I remember there's also a `meta` property available, which is a convenient place to drop our meta-data about a field being an array value, for internal processing. Bonus, it can live in the generated mappings as well. references: - https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-field-meta.html - https://www.elastic.co/guide/en/elasticsearch/reference/current/dynamic.html
pmuellr
added a commit
that referenced
this pull request
Mar 30, 2020
resolves #58518 Changes the object properties in the eventLog mappings to use `dynamic: false` instead of `dynamic: strict`. This provides a bit of a safety net for cases where the mappings change during development, or potentially in production cases. Rather than completely lose entire events and see errors in logs, we'll silently drop properties from events. While researching the `dynamic` property, I remember there's also a `meta` property available, which is a convenient place to drop our meta-data about a field being an array value, for internal processing. Bonus, it can live in the generated mappings as well. references: - https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-field-meta.html - https://www.elastic.co/guide/en/elasticsearch/reference/current/dynamic.html Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #58518
Changes the object properties in the eventLog mappings to use
dynamic: falseinstead of
dynamic: strict. This provides a bit of a safety net for caseswhere the mappings change during development, or potentially in production
cases. Rather than completely lose entire events and see errors in logs, we'll
silently drop properties from events.
The
dynamicsetting on all inner objects isn't actually needed, it's inherited from the top.While researching the
dynamicproperty, I remember there's also ametaproperty available, which is a convenient place to drop our meta-data about
a field being an array value, for internal processing. Bonus, it can live in
the generated mappings as well.
references: