-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data.search.aggs] Remove service getters from agg types #61628
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c193b74
[data.search.aggs] Remove service getters from agg types
alexwizp 775eaaf
Merge branch 'master' into #60333
elasticmachine 70ccb9c
Merge branch 'master' into #60333
elasticmachine cc74e3a
Merge branch 'master' into #60333
elasticmachine d4b8323
Merge branch 'master' into #60333
elasticmachine 845261d
Merge branch 'master' into #60333
elasticmachine b892dfe
Merge branch 'master' into #60333
elasticmachine 474f75f
new portion of changes
alexwizp ff0cdf0
pass dependencies to MetricAgg Type through constructor
alexwizp 44d5105
update docs
alexwizp 889b150
Merge remote-tracking branch 'upstream/master' into #60333
alexwizp 039bc37
refactoring buckets
alexwizp 27ef9b3
remove unused mockDataServices
alexwizp 2b9087d
Remove service getters from metrics
VladLasitsa cb70801
Some fixes
VladLasitsa 14df4e5
remove temporary code
alexwizp 43750da
moved notifications to the getInternalStartServices
VladLasitsa ddb9fc5
fixed karma lock
VladLasitsa b9e08ba
update docs
alexwizp 0ec6f9e
Fixed tests
VladLasitsa fb3e918
Merge branch 'master' into #60333
elasticmachine 40beba8
fix broken CI
alexwizp dd539e0
fix PR comment
alexwizp 0eb723e
fix typo
alexwizp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import { FieldFormatsStart, FieldFormatsSetup, FieldFormatsService } from '.'; | ||
import { fieldFormatsMock } from '../../common/field_formats/mocks'; | ||
|
||
type FieldFormatsServiceClientContract = PublicMethodsOf<FieldFormatsService>; | ||
|
||
const createSetupContractMock = () => fieldFormatsMock as FieldFormatsSetup; | ||
const createStartContractMock = () => fieldFormatsMock as FieldFormatsStart; | ||
|
||
const createMock = () => { | ||
const mocked: jest.Mocked<FieldFormatsServiceClientContract> = { | ||
setup: jest.fn().mockReturnValue(createSetupContractMock()), | ||
start: jest.fn().mockReturnValue(createStartContractMock()), | ||
}; | ||
|
||
return mocked; | ||
}; | ||
|
||
export const fieldFormatsServiceMock = { | ||
create: createMock, | ||
createSetupContract: createSetupContractMock, | ||
createStartContract: createStartContractMock, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we can remove
getters/setters
altogether, but now using this approach we can save support of two ways for passing dependencies and refactor all places without any rush.