Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Import timeline schema update #61622

Merged
merged 14 commits into from
Mar 30, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Mar 27, 2020

Summary

This PR is to fix https://github.com/elastic/siem-team/issues/568

To verify this PR please download the file below, remove .txt and import the file with .ndjson and see if it success or not.
timelines_export_bc1_qa.ndjson.txt

The prototype of the import schemas comes from
timeline: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/siem/server/lib/timeline/saved_object_mappings.ts
pinnedEvent: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/siem/server/lib/pinned_event/saved_object_mappings.ts
note: https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/siem/server/lib/note/saved_object_mappings.ts

keyword is mapped to Joi.string()
date is mapped to Joi.number()
text is mapped to allowEmptyString
boolean is mapped to Joi.boolean().allow(null)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@angorayc angorayc requested a review from a team as a code owner March 27, 2020 13:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit c0c9d98 into elastic:master Mar 30, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Mar 30, 2020
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized

* unit test for TimelinesPageComponent

* update schemas

* update schema

Co-authored-by: Elastic Machine <[email protected]>
angorayc added a commit to angorayc/kibana that referenced this pull request Mar 30, 2020
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized

* unit test for TimelinesPageComponent

* update schemas

* update schema

Co-authored-by: Elastic Machine <[email protected]>
angorayc added a commit that referenced this pull request Mar 30, 2020
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized

* unit test for TimelinesPageComponent

* update schemas

* update schema

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
angorayc added a commit that referenced this pull request Mar 30, 2020
* allow users importing data if they are authorized

* rename props

* rename types

* hide import timeline btn if unauthorized

* unit test for TimelinesPageComponent

* update schemas

* update schema

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants