-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move src/legacy/server/index_patterns
to data plugin (server) (Remove step)
#61618
Move src/legacy/server/index_patterns
to data plugin (server) (Remove step)
#61618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks LGTM! but we still have some references to indexPatternsServiceFactory
At least in these files:
src/legacy/server/saved_objects/saved_objects_mixin.test.js
x-pack/plugins/infra/server/lib/adapters/framework/adapter_types.ts
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
infra
changes LGTM, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM (have not tested locally though).
Just one request: Could we add release_note:dev_docs
to this with a few sentences describing the deprecation and directing folks to replace usages with IndexPatternsFetcher
?
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…ve step) (elastic#61618) * Removed legacy index pattern * fix type * remove unnecessary import * Removed old references to indexPatternsServiceFactory Co-authored-by: Elastic Machine <[email protected]>
…ve step) (#61618) (#62280) * Removed legacy index pattern * fix type * remove unnecessary import * Removed old references to indexPatternsServiceFactory Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: Switch to embeddable factory interface with optional override (elastic#61165) fix text error in diagrams (elastic#62101) [Index management] Prepare support Index template V2 format (elastic#61588) Updates dashboard images (elastic#62011) [Maps] remove MapBounds type (elastic#62332) [Uptime] Convert anomaly Jobs name to lowercase to comply with… (elastic#62293) Make d3 place nicely with object values (elastic#62004) EMT-287: update schema with elastic agent id (elastic#62252) [Maps] fix replaceLayerList to handle case where map is not intialized (elastic#62202) Remove support for deprecated xpack.telemetry configurations (elastic#51142) [Uptime] Remove static constant for index name completely (elastic#62256) [APM] E2E: install dependencies for vanilla workspaces (elastic#62178) [backport] Bump to 5.1.3 (elastic#62286) Show server name in Remote Cluster detail panel (elastic#62250) Rename some alert types (elastic#61693) changing duration type to ms, s, m (elastic#62265) [ML] Clear Kibana index pattern cache on creation or form reset. (elastic#62184) Move `src/legacy/server/index_patterns` to data plugin (server) (Remove step) (elastic#61618) [NP] Remove IndexedArray usage in Schemas (elastic#61410)
Part of #44190
Summary
Delete src/legacy/server/index_patterns
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Dev docs
The legacy folder
src / legacy / server / index_patterns
has been deleted due to the fact that we have already moved the corresponding code to the new platform.For more information on where to locate new platform
data
services, please refer to the table of plugins for shared application services insrc/core/MIGRATION.md
.