Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - stabilize advanced wizard tests #61579

Merged
merged 2 commits into from
Mar 27, 2020
Merged

[ML] Functional tests - stabilize advanced wizard tests #61579

merged 2 commits into from
Mar 27, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 27, 2020

Summary

This PR stabilizes the anomaly detection wizard tests by adding a retry to the wizard navigation.

Closes #61562
Closes #61563

@pheyos pheyos self-assigned this Mar 27, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v8.0.0 labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos added v7.8.0 and removed v7.7.0 labels Mar 27, 2020
@pheyos pheyos marked this pull request as ready for review March 27, 2020 11:59
@pheyos pheyos requested a review from a team as a code owner March 27, 2020 11:59
@pheyos
Copy link
Member Author

pheyos commented Mar 27, 2020 •
edited
Loading

Verified test stability:

job result
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/303/ no failure in 40 runs
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/304/ no failure in 40 runs
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/305/ no failure in 40 runs (just one unrelated Kibana timeout)

Summary: with this fix, advanced wizard tests had no failure in 120 runs.

walterra
walterra approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@pheyos pheyos merged commit 91c437d into elastic:master Mar 27, 2020
@pheyos pheyos deleted the fix_advanced_wizard_tests branch March 27, 2020 13:59
@pheyos pheyos mentioned this pull request Mar 27, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 27, 2020
@pheyos
[ML] Functional tests - stabilize advanced wizard tests (elastic#61579)
c453493 
This PR stabilizes the anomaly detection wizard tests by adding a retry to the wizard navigation.
pheyos added a commit that referenced this pull request Mar 27, 2020
@pheyos
[ML] Functional tests - stabilize advanced wizard tests (#61579) (#61626
8b939ad 
)

This PR stabilizes the anomaly detection wizard tests by adding a retry to the wizard navigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@peteharverson peteharverson Awaiting requested review from peteharverson

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@pheyos @kibanamachine @elasticmachine @walterra @alvarezmelissa87