-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Enrollment keys list page #61346
[Fleet] Enrollment keys list page #61346
Conversation
Pinging @elastic/ingest-management (Feature:EPM) |
9339c65
to
fcec414
Compare
fcec414
to
877d1ba
Compare
…t-fleet-enrollment-key-list-page
Hey @nchaulet - thanks! Could you remove the heading "Enrollment tokens" which appear below the page tabs? It's redundant and pushes the content a bit too far down the page. If possible, could you do the same to the Agents page? |
bc9d961
to
e02ea5e
Compare
Looks good! A few comments... Getting react warnings for an invalid date for the default config. If there is no date perhaps we can handle it some other way? Or should default config have a date? Since we can't adjust the column widths, can we add a "title" tag so when the token key is long and truncated we can see all of it? @hbharding Not sure what the purpose is of having two buttons here. If I click "create enrollment token" the flyout continues so you never click "continue". If I don't click "create enrollment token" and just click "continue" the flyout closes and nothing happens. @hbharding |
…t-fleet-enrollment-key-list-page
@neptunian Thanks for the review, I removed the continue button from the flyout, I think it does not make sense here. I added the title to the truncated name. We should always have a |
70436a7
to
a70683e
Compare
* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/feature_controls/ml_security·ts.machine learning feature controls security machine_learning_user and global all shows ML navlinkStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/feature_controls/ml_security·ts.machine learning feature controls security machine_learning_user and global all shows ML navlinkStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/documents_source/docvalue_fields·js.maps app documents source docvalue_fields should only fetch geo_point field and data driven styling fieldsStandard Out
Stack Trace
and 1 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
Summary
Add the enrollement token list page, this page allow to view and manage enrollment tokens.
Done in this PR:
UI Changes
API Change
The delete API is now not deleting the enrollment key anymore but marking it as inactive, what are your thoughts on that? I think it's interesting to keep a trace of old enrollment keys for investigation, ...