Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixes Anomaly Explorer swimlane label and chart tooltips #61327

Merged
merged 2 commits into from
Mar 26, 2020
Merged

[ML] Fixes Anomaly Explorer swimlane label and chart tooltips #61327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa1511c
[ML] Fixes Anomaly Explorer swimlane label and chart tooltips
peteharverson Mar 25, 2020
fb9fd9d
Merge branch 'master' into ml-explorer-tooltip-fixes
elasticmachine Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/plugins/ml/public/application/explorer/explorer_charts/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import 'components/explorer_chart_label/index';
@import 'explorer_chart';
@import 'explorer_chart_tooltip';
@import 'explorer_charts_container';
@import 'explorer_charts_container';
1 change: 1 addition & 0 deletions ...lication/explorer/explorer_charts/components/explorer_chart_label/explorer_chart_label.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import './_explorer_chart_label.scss';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_chart_info_tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import './_explorer_chart_tooltip.scss';
import PropTypes from 'prop-types';
import React from 'react';

Expand Down
14 changes: 11 additions & 3 deletions x-pack/plugins/ml/public/application/explorer/explorer_swimlane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,17 @@ export class ExplorerSwimlane extends React.Component {
.each(function() {
if (swimlaneData.fieldName !== undefined) {
d3.select(this)
.on('mouseover', label => {
.on('mouseover', value => {
mlChartTooltipService.show(
[{ skipHeader: true }, { name: swimlaneData.fieldName, value: label }],
[
{ skipHeader: true },
{
label: swimlaneData.fieldName,
value,
seriesIdentifier: { key: value },
valueAccessor: 'fieldName',
},
],
this,
{
x: laneLabelWidth,
Expand All @@ -400,7 +408,7 @@ export class ExplorerSwimlane extends React.Component {
.on('mouseout', () => {
mlChartTooltipService.hide();
})
.attr('aria-label', label => `${mlEscape(swimlaneData.fieldName)}: ${mlEscape(label)}`);
.attr('aria-label', value => `${mlEscape(swimlaneData.fieldName)}: ${mlEscape(value)}`);
}
});

Expand Down