Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Fix cloud tests (NP version of #59040) #61271

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Mar 25, 2020

Summary

Fix allowChangingOptInStatus savedObject attribute not being able to get updated. Fixes test case for opt in api failing on cloud with allowChangingOptInStatus: false config set.

Adds test cases for opt in route with respect to allowChangingOptInStatus flag.

Closes #51522

This is basically a reimplementation of #59040 for the NP. I thought it was easier than merging master into that one.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@afharo afharo added the release_note:skip Skip the PR/issue when compiling release notes label Mar 25, 2020
@afharo
Copy link
Member Author

afharo commented Mar 25, 2020

Q: Should we still aim this PR to the label 7.7.0 and 7.6.2 as the original.

Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 11bcfae into elastic:master Mar 25, 2020
@afharo afharo deleted the telemetry/fix-cloud-tests branch March 25, 2020 16:37
afharo added a commit to afharo/kibana that referenced this pull request Mar 25, 2020
afharo added a commit to afharo/kibana that referenced this pull request Mar 25, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 27, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@afharo
Copy link
Member Author

afharo commented Mar 27, 2020

Apparently the backported build never finished so no email about the build done was sent and I forgot to proactively check. Updated the backport branch and rebuilding...

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 27, 2020
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v7.8.0 v8.0.0
Projects
None yet
5 participants