Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search interceptor toast lifetime #61133

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

lukasolson
Copy link
Member

Summary

There seems to be a bug in the toasts that doesn't allow you to specify Infinity as the lifetime. Instead, you'll see the toast for a split second and then it will disappear. While trying to find out why that's the case, I've updated the search interceptor toasts to last for 1000000 instead of Infinity.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 24, 2020
@lukasolson lukasolson requested a review from lizozom March 24, 2020 18:22
@lukasolson lukasolson requested a review from a team as a code owner March 24, 2020 18:22
@lukasolson lukasolson self-assigned this Mar 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 75aa207 into elastic:master Mar 25, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Mar 26, 2020
lizozom pushed a commit that referenced this pull request Mar 26, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Mar 26, 2020
lukasolson added a commit that referenced this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants