-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add error steps and help links to PR comments #60772
Conversation
Example for posterity 💔 Build Failed
Failed CI Steps
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-operations (Team:Operations) |
@@ -0,0 +1,21 @@ | |||
def getSteps() { | |||
def url = "${env.BUILD_URL}api/json?tree=actions[nodes[iconColor,running,displayName,id,parents]]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating URLs with proper tools looks like this:
def builder = new URIBuilder(env.BUILD_URL)
def url = builder
.setPathSegments(builder.getPathSegments() + ['api', 'json'])
.setParameter('tree', 'actions[nodes[iconColor,running,displayName,id,parents]]')
.toString()
and actually produces incorrectly-formatted URLs, e.g.
https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/34782//api/json?tree=actions%5Bnodes%5BiconColor%2Crunning%2CdisplayName%2Cid%2Cparents%5D%5D
(notice the double //
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/settings·ts.Uptime app with generated data uptime settings page changing index pattern setting is reflected elsewhere in UIStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
* master: [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) [CI] Add error steps and help links to PR comments (elastic#60772) skip flaky functional test (elastic#60898) [Alerting] Fixes mistake in empty list assertion (elastic#60896) a11y tests for login and logout (elastic#60799) removed boom errors from AlertNavigationRegistry (elastic#60887)
Add links to CI help page and directly to failed pipeline steps to PR comments.
I considered limiting the number of failed steps that will show up in the comment, but am currently choosing to let them all through and change it later if it ends up being an issue.
I'm filtering out git checkout errors, since those happen on so many jobs and aren't useful.
See below for example.