Add async search notification

[lizozom]

Summary

Depends on #60574

Resolves #24227.
Resolves #46370.

Add async search notification.

• Cancel \ Run beyond timeout work in Basic license
• In OSS the notification has disabled buttons, and a Learn More link (taking where?)
• The notifications shows after a query runs for at least 10 seconds
• When a query finishes running, the toast is dismissed.

In OSS:

In Basic:

Dev Docs

The async search feature allows users with a Basic license and above, execute long queries. By default, query execution is limited to 30 second time frame. Now Discover, Visualize and most importantly Dashboard applications, will present the user an option to run a query beyond timeout.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-https://github.com/elastic/kibana/pull/60574browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[mdefazio]

Here are a few things I'm noticing (and questions I have):

1. The icons tend to take awhile to load even when the toast appears. Let's just remove the icon in this instance then.
   

2. I don't think we need the cancel button. And so we can also turn the 'Run beyond timeout' button to a hollow button to better align with the EUI toast guidelines.

3. Does the timeout toast stay on screen all the way until the search completes? I received other timeout errors after it appeared and when those disappeared, so did the timeout toast.

4. I know we're going back-and-forth on the copy still, but I don't see a need for the 'Learn more' here. We are only providing a link out if they do not have the functionality available to them (in which case it would be 'Upgrade' or something as you mentioned in the copy doc). And the description isn't necessary either. So for this version, I think the end result would be like this:
   

5. Does the timer for the toast only start once the Kibana chrome has loaded (after the main Kibana loading screen)? And is the timer set for 10 sec? I wasn't able to tell a consistent time on my end. Is there a difference between a slow connection load, and a fast connection, large data load for when the timer starts to show the toast?

6. If we hit the timeout, do we dismiss the toast and then show a timeout error toast? I didn't see this on my end. I just saw the timeout toasts for the individual visualizations.

[lukasolson]

Made a couple of comments below, maybe we can sync on these things together.

[lizozom]

Here are a few things I'm noticing (and questions I have):

The icons tend to take awhile to load even when the toast appears. Let's just remove the icon in this instance then.

The behavior of icons on notifications is the same for all types of notifications (they all have icons). And this won't happen if you didn't slow down the network intentionally.

I don't think we need the cancel button. And so we can also turn the 'Run beyond timeout' button to a hollow button to better align with the EUI toast guidelines.

@AlonaNadler should I remove the cancel button altogether?

Does the timeout toast stay on screen all the way until the search completes? I received other timeout errors after it appeared and when those disappeared, so did the timeout toast.

Fixed. Now it will stay on screen until search completes.

I know we're going back-and-forth on the copy still, but I don't see a need for the 'Learn more' here. We are only providing a link out if they do not have the functionality available to them (in which case it would be 'Upgrade' or something as you mentioned in the copy doc). And the description isn't necessary either. So for this version, I think the end result would be like this:

Updated to the copy from the doc. You can see updated screenshots on the issue.

Does the timer for the toast only start once the Kibana chrome has loaded (after the main Kibana loading screen)? And is the timer set for 10 sec? I wasn't able to tell a consistent time on my end. Is there a difference between a slow connection load, and a fast connection, large data load for when the timer starts to show the toast?

The timer starts from the moment the search request is being sent.

If we hit the timeout, do we dismiss the toast and then show a timeout error toast? I didn't see this on my end. I just saw the timeout toasts for the individual visualizations.

Yes, that's the behavior - cancel the notification and show an error.

[AlonaNadler]

I read @mdefazio suggestions, not sure I understand why to remove the cancel button

[mdefazio]

I read @mdefazio suggestions, not sure I understand why to remove the cancel button

@AlonaNadler At this stage, doing any action on the dashboard/page would in effect cancel the request. We also try and keep toasts to a single CTA. I know things will change in 7.8, so I'm not saying we don't need it then. But it feels a bit unnecessary now.

[mdefazio]

@lukasolson if we decide to remove the cancel button, then I'd also suggest changing the button style to hollow. If we keep it though, then no other changes on my end.

[lukasolson]

LGTM!

[mdefazio]

LGTM!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: fb7e930

History

• 💚 Build #35739 succeeded fb7e930
• 💔 Build #35654 failed 716b54b
• 💔 Build #35486 failed 8eebe08
• 💔 Build #35471 failed 82945af
• 💔 Build #35355 failed f02fa89

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream