Add pipeline support to Ingest API #6070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbudz this is the new PR targeting the feature/ingest branch instead of master. If you run this PR against a fresh installation of Elasticsearch master everything in the API should work. Tests will fail since I only made the minimum change to get Kibana to start up with ES master, but that's why I'm targeting the feature/ingest branch so that I can continue working on features that need this API. I updated the code so that TypeError you were seeing should throw a more user friendly 500 error now. If you have the time, I'd appreciate any other feedback you have! |
|
LGTM |
Bargs
pushed a commit
that referenced
this pull request
Feb 8, 2016
Add pipeline support to Ingest API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6034 since merging into master would break tests due to dependency on ES master.
Requires #5656 and a build of Elasticsearch with the ingest functionality (at time of writing, a build of the master branch)
This PR adds pipeline support to the ingest API.
If you like Postman, import this collection with example requests to play around with.
An array of processors can be included under a
pipelinekey in the JSON payload provided to the POST endpoint. The Kibana ingest API will use this list of processors to create an ES ingest pipeline. As a result, you'll need to test this PR against a build from ES master (or clone the ES repo and rungradle run).I've created a ticket to add API tests once Kibana master has been updated to track ES master (#6035).