Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing file data visualizer override arguments #60627

Merged
merged 1 commit into from
Mar 19, 2020
Merged

[ML] Fixing file data visualizer override arguments #60627

merged 1 commit into from
Mar 19, 2020

Conversation

jgowdyelastic
Copy link
Member

Fixes problems caused by changes to the url query parameters in PR #59928

Column names were being sent as an array which was used to stringyfied by default, this no longer happens so they need to be joined to produce the string.

The grok pattern was originally being encoded manually, this now happens by default.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v7.7.0 labels Mar 19, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 19, 2020 14:04
@jgowdyelastic jgowdyelastic self-assigned this Mar 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit a0730f7 into elastic:master Mar 19, 2020
@jgowdyelastic jgowdyelastic deleted the fixing-file-dataviz-override-arguments branch March 19, 2020 16:43
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 19, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 19, 2020
@jgowdyelastic
[ML] Fixing file data visualizer override arguments (elastic#60627)
f4e7268
jgowdyelastic added a commit that referenced this pull request Mar 19, 2020
@jgowdyelastic
[ML] Fixing file data visualizer override arguments (#60627) (#60654)
24ffb19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson