-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Create factories via plugin start contract, allow overriding #60591
Closed
stacey-gammon
wants to merge
1
commit into
elastic:master
from
stacey-gammon:2020-03-18-embed-factory-create
Closed
[wip] Create factories via plugin start contract, allow overriding #60591
stacey-gammon
wants to merge
1
commit into
elastic:master
from
stacey-gammon:2020-03-18-embed-factory-create
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
force-pushed
the
2020-03-18-embed-factory-create
branch
2 times, most recently
from
March 19, 2020 02:38
556dc5b
to
0b2a0d9
Compare
stacey-gammon
force-pushed
the
2020-03-18-embed-factory-create
branch
from
March 19, 2020 03:43
0b2a0d9
to
6d105b5
Compare
💔 Build FailedTest FailuresKibana Pipeline / kibana-oss-agent / Accessibility Tests.test/accessibility/apps/dashboard·ts.Dashboard add a visualizationStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_time_picker·js.dashboard app using legacy data dashboard time picker Visualization updated when time picker changesStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_time_picker·js.dashboard app using legacy data dashboard time picker Visualization updated when time picker changesStandard Out
Stack Trace
and 13 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
thomasneirynck
added
the
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
label
Mar 19, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
added
Team:AppArch
and removed
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
labels
Mar 23, 2020
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Close infavor of #61165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.