Implemented ability to clear and properly validate alert interval #60571

YulNaumenko · 2020-03-18T21:55:42Z

elasticmachine · 2020-03-18T21:55:44Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

pmuellr

Suggested a change to replace some string-replace-with-regex usage for a duration string, with some new function to add to our common duration parser.

Beyond that LGTM, works fine in the UI.

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx

mikecote

The alert interval changes LGTM. I noticed the issue had a follow up comment of another place that has the same problem #59929 (comment) but doesn't seem fixed in this PR?

pmuellr

LGTM

kibanamachine · 2020-03-20T05:05:05Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 92609c3
Flaky suites:
- xpack-kibana-ciGroup8

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_spaces·ts.discover feature controls spaces space with no features disabled shows "visualize" field button

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/60559

[00:00:00]       │
[00:00:00]         └-: discover
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: feature controls
[00:00:00]             └-> "before all" hook
[00:00:00]             └-: spaces
[00:00:00]               └-> "before all" hook
[00:00:00]               └-> "before all" hook
[00:00:00]                 │ info [logstash_functional] Loading "mappings.json"
[00:00:00]                 │ info [logstash_functional] Loading "data.json.gz"
[00:00:00]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]]).
[00:00:00]                 │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:00]                 │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]]).
[00:00:00]                 │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:00]                 │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]]).
[00:00:00]                 │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:00]                 │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:10]                 │ info progress: 6315
[00:00:17]                 │ info [logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:00:17]                 │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:17]                 │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:00:18]               └-: space with no features disabled
[00:00:18]                 └-> "before all" hook
[00:00:18]                 └-> "before all" hook
[00:00:18]                   │ info [discover/feature_controls/spaces] Loading "mappings.json"
[00:00:18]                   │ info [discover/feature_controls/spaces] Loading "data.json"
[00:00:18]                   │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_1/qO0VVgbrTk2oRFjBdkpR3A] deleting index
[00:00:18]                   │ info [discover/feature_controls/spaces] Deleted existing index [".kibana_1"]
[00:00:18]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:18]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]]).
[00:00:18]                   │ info [discover/feature_controls/spaces] Created index ".kibana"
[00:00:18]                   │ debg [discover/feature_controls/spaces] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:00:18]                   │ info [discover/feature_controls/spaces] Indexed 4 docs into ".kibana"
[00:00:18]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana/QuL7b-aVTrG37kAxFcndYA] update_mapping [_doc]
[00:00:18]                   │ debg Migrating saved objects
[00:00:19]                   │ proc [kibana]   log   [03:59:08.583] [info][savedobjects-service] Creating index .kibana_2.
[00:00:19]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:19]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:19]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]]).
[00:00:19]                   │ proc [kibana]   log   [03:59:08.757] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:00:19]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:20]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:20]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]]).
[00:00:20]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:20]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] updating number_of_replicas to [0] for indices [.tasks]
[00:00:20]                   │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.tasks][0]]]).
[00:00:20]                   │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] 1643 finished with response BulkByScrollResponse[took=81.9ms,timed_out=false,sliceId=null,updated=0,created=5,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:20]                   │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana/QuL7b-aVTrG37kAxFcndYA] deleting index
[00:00:20]                   │ proc [kibana]   log   [03:59:09.316] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:20]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_2/mL-g5Hx0QpqUrF80QtqH1w] update_mapping [_doc]
[00:00:20]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_2/mL-g5Hx0QpqUrF80QtqH1w] update_mapping [_doc]
[00:00:20]                   │ proc [kibana]   log   [03:59:09.558] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:20]                   │ proc [kibana]   log   [03:59:09.675] [info][savedobjects-service] Finished in 1096ms.
[00:00:20]                   │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:21]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_2/mL-g5Hx0QpqUrF80QtqH1w] update_mapping [_doc]
[00:00:21]                   │ debg creating space
[00:00:22]                   │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.kibana_2/mL-g5Hx0QpqUrF80QtqH1w] update_mapping [_doc]
[00:00:22]                   │ debg created space
[00:00:22]                 └-> shows discover navlink
[00:00:22]                   └-> "before each" hook: global before each
[00:00:22]                   │ debg navigating to home url: http://localhost:6181/s/custom_space/app/kibana#/home
[00:00:22]                   │ debg Navigate to: http://localhost:6181/s/custom_space/app/kibana#/home
[00:00:23]                   │ debg ... sleep(700) start
[00:00:23]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/login?next=%2Fs%2Fcustom_space%2Fapp%2Fkibana%3F_t%3D1584676751760#/home 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:23]                   │
[00:00:23]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:23]                   │ debg ... sleep(700) end
[00:00:23]                   │ debg returned from get, calling refresh
[00:00:24]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/login?next=%2Fs%2Fcustom_space%2Fapp%2Fkibana%3F_t%3D1584676751760#/home 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:24]                   │
[00:00:24]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/core/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:24]                   │ debg currentUrl = http://localhost:6181/s/custom_space/login?next=%2Fs%2Fcustom_space%2Fapp%2Fkibana%3F_t%3D1584676751760#/home
[00:00:24]                   │          appUrl = http://localhost:6181/s/custom_space/app/kibana#/home
[00:00:24]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:32]                   │ proc [kibana]   log   [03:59:21.226] [warning][plugins][spaces] Error toggling capabilities for request to /api/core/capabilities: [security_exception] missing authentication credentials for REST request [/_security/user/_has_privileges], with { header={ WWW-Authenticate={ 0="ApiKey" & 1="Basic realm=\"security\" charset=\"UTF-8\"" } } } :: {"path":"/_security/user/_has_privileges","query":{},"body":"{\"applications\":[{\"application\":\"kibana-.kibana\",\"resources\":[\"space:custom_space\"],\"privileges\":[\"version:8.0.0-SNAPSHOT\",\"login:\"]}]}","statusCode":401,"response":"{\"error\":{\"root_cause\":[{\"type\":\"security_exception\",\"reason\":\"missing authentication credentials for REST request [/_security/user/_has_privileges]\",\"header\":{\"WWW-Authenticate\":[\"ApiKey\",\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\"]}}],\"type\":\"security_exception\",\"reason\":\"missing authentication credentials for REST request [/_security/user/_has_privileges]\",\"header\":{\"WWW-Authenticate\":[\"ApiKey\",\"Basic realm=\\\"security\\\" charset=\\\"UTF-8\\\"\"]}},\"status\":401}","wwwAuthenticateDirective":"ApiKey, Basic realm=\"security\" charset=\"UTF-8\""}
[00:00:32]                   │ debg Found login page
[00:00:32]                   │ debg TestSubjects.setValue(loginUsername, test_user)
[00:00:32]                   │ debg TestSubjects.click(loginUsername)
[00:00:32]                   │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:32]                   │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:32]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-20T03:59:21Z
[00:00:32]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:00:32]                   │
[00:00:32]                   │      "
[00:00:33]                   │ debg TestSubjects.setValue(loginPassword, changeme)
[00:00:33]                   │ debg TestSubjects.click(loginPassword)
[00:00:33]                   │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:33]                   │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:33]                   │ debg TestSubjects.click(loginSubmit)
[00:00:33]                   │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:33]                   │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:33]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"] nav:not(.ng-hide)') with timeout=60000
[00:00:46]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676751760#/home 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:46]                   │
[00:00:46]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:46]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-20T03:59:30Z
[00:00:46]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:00:46]                   │
[00:00:46]                   │      "
[00:00:47]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676775055#/home 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:47]                   │
[00:00:47]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:47]                   │ debg Finished login process currentUrl = http://localhost:6181/s/custom_space/app/kibana#/home
[00:00:47]                   │ debg TestSubjects.find(kibanaChrome)
[00:00:47]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:00:58]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-20T03:59:44Z
[00:00:58]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:00:58]                   │
[00:00:58]                   │      "
[00:00:59]                   │ debg ... sleep(501) start
[00:00:59]                   │ debg ... sleep(501) end
[00:00:59]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/home
[00:00:59]                   │ debg TestSubjects.exists(statusPageContainer)
[00:00:59]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:02]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:02]                   │ debg TestSubjects.find(navDrawer)
[00:01:02]                   │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:01:02]                   └- ✓ pass  (39.9s) "discover feature controls spaces space with no features disabled shows discover navlink"
[00:01:02]                 └-> shows save button
[00:01:02]                   └-> "before each" hook: global before each
[00:01:02]                   │ debg navigating to discover url: http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:02]                   │ debg Navigate to: http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:03]                   │ debg ... sleep(700) start
[00:01:03]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676791618#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:03]                   │
[00:01:03]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:03]                   │ debg ... sleep(700) end
[00:01:03]                   │ debg returned from get, calling refresh
[00:01:05]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676791618#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:05]                   │
[00:01:05]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:06]                   │ debg currentUrl = http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:06]                   │          appUrl = http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:06]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:12]                   │ debg TestSubjects.find(kibanaChrome)
[00:01:12]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:01:12]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-20T04:00:00Z
[00:01:12]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:01:12]                   │
[00:01:12]                   │      "
[00:01:12]                   │ debg ... sleep(501) start
[00:01:13]                   │ debg ... sleep(501) end
[00:01:13]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:01:13]                   │ debg --- retry.try error: URL changed, waiting for it to settle
[00:01:14]                   │ debg ... sleep(501) start
[00:01:14]                   │ debg ... sleep(501) end
[00:01:14]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:01:14]                   │ debg TestSubjects.exists(statusPageContainer)
[00:01:14]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:17]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:17]                   │ debg TestSubjects.exists(discoverSaveButton)
[00:01:17]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverSaveButton"]') with timeout=20000
[00:01:18]                   └- ✓ pass  (15.2s) "discover feature controls spaces space with no features disabled shows save button"
[00:01:18]                 └-> shows "visualize" field button
[00:01:18]                   └-> "before each" hook: global before each
[00:01:18]                   │ debg navigating to discover url: http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:18]                   │ debg Navigate to: http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:18]                   │ debg ... sleep(700) start
[00:01:18]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676806860#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:18]                   │
[00:01:18]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:19]                   │ debg ... sleep(700) end
[00:01:19]                   │ debg returned from get, calling refresh
[00:01:19]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/app/kibana?_t=1584676806860#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:19]                   │
[00:01:19]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:20]                   │ debg currentUrl = http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:20]                   │          appUrl = http://localhost:6181/s/custom_space/app/kibana#/discover
[00:01:20]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:25]                   │ debg TestSubjects.find(kibanaChrome)
[00:01:25]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:01:25]                   │ debg browser[INFO] http://localhost:6181/s/custom_space/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-03-20T04:00:12Z
[00:01:25]                   │        Adding connection to http://localhost:6181/s/custom_space/elasticsearch
[00:01:25]                   │
[00:01:25]                   │      "
[00:01:25]                   │ debg ... sleep(501) start
[00:01:25]                   │ debg ... sleep(501) end
[00:01:26]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:01:26]                   │ debg --- retry.try error: URL changed, waiting for it to settle
[00:01:26]                   │ debg ... sleep(501) start
[00:01:27]                   │ debg ... sleep(501) end
[00:01:27]                   │ debg in navigateTo url = http://localhost:6181/s/custom_space/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:01:27]                   │ debg TestSubjects.exists(statusPageContainer)
[00:01:27]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:29]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:30]                   │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:01:30]                   │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:01:30]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:01:30]                   │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:01:30]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:01:30]                   │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:01:30]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:01:30]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:01:30]                   │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:01:30]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:01:30]                   │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:01:30]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:01:30]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:01:30]                   │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:01:31]                   │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:01:31]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:01:31]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:01:31]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:01:31]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:31]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:31]                   │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:01:31]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:01:31]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:31]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:32]                   │ debg ... sleep(500) start
[00:01:33]                   │ debg ... sleep(500) end
[00:01:33]                   │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:01:33]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:01:33]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:01:33]                   │ debg Find.waitForElementStale with timeout=10000
[00:01:33]                   │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:01:33]                   │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:01:33]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:01:33]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:01:34]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:01:34]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:34]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:34]                   │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:01:34]                   │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:01:34]                   │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:34]                   │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:01:35]                   │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:01:35]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:01:38]                   │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:01:38]                   │ debg TestSubjects.click(querySubmitButton)
[00:01:38]                   │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:01:38]                   │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:01:39]                   │ debg Find.waitForElementStale with timeout=10000
[00:01:39]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:39]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:40]                   │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1584674417396251480] [.async-search] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:01:40]                   │ debg TestSubjects.click(field-bytes)
[00:01:40]                   │ debg Find.clickByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:01:40]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:01:50]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:01:50]                   │      Wait timed out after 10061ms
[00:01:51]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:01]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:02:01]                   │      Wait timed out after 10013ms
[00:02:01]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:11]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:02:11]                   │      Wait timed out after 10028ms
[00:02:12]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:22]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:02:22]                   │      Wait timed out after 10044ms
[00:02:22]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:32]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:02:32]                   │      Wait timed out after 10029ms
[00:02:33]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:43]                   │ debg --- retry.try failed again with the same message...
[00:02:43]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:02:53]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:02:53]                   │      Wait timed out after 10039ms
[00:02:54]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:03:04]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:03:04]                   │      Wait timed out after 10018ms
[00:03:04]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:03:14]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:03:14]                   │      Wait timed out after 10017ms
[00:03:15]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:03:25]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:03:25]                   │      Wait timed out after 10012ms
[00:03:26]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:03:36]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:03:36]                   │      Wait timed out after 10018ms
[00:03:36]                   │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:03:46]                   │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
[00:03:46]                   │      Wait timed out after 10061ms
[00:03:47]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/discover feature controls spaces space with no features disabled shows _visualize_ field button.png"
[00:03:47]                   │ info Current URL is: http://localhost:6181/s/custom_space/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:03:47]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/discover feature controls spaces space with no features disabled shows _visualize_ field button.html
[00:03:47]                   └- ✖ fail: "discover feature controls spaces space with no features disabled shows "visualize" field button"
[00:03:47]                   │

Stack Trace

Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="field-bytes"])
Wait timed out after 10061ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (/dev/shm/workspace/kibana/test/common/services/retry/retry_for_success.ts:68:13)

History

💔 Build #34612 failed 198ca72
💔 Build #34356 failed 7fdfee6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mikecote

LGTM

…astic#60571) * Implemented ability to clear and properly validate alert interval * Fixed due to comments * Fixed additional request for the last field * Fixed failing test

* master: (52 commits) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) ...

…astic#60571) * Implemented ability to clear and properly validate alert interval * Fixed due to comments * Fixed additional request for the last field * Fixed failing test

* master: (55 commits) Update dependency @elastic/charts to v18.1.0 (elastic#60578) Only set timezone when user setting is a valid timezone (elastic#57850) [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) ...

* master: Only set timezone when user setting is a valid timezone (elastic#57850) [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221)

…0571) (#60778) * Implemented ability to clear and properly validate alert interval * Fixed due to comments * Fixed additional request for the last field * Fixed failing test

Implemented ability to clear and properly validate alert interval

7fdfee6

YulNaumenko added bug Fixes for quality problems that affect the customer experience Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Mar 18, 2020

YulNaumenko requested a review from a team as a code owner March 18, 2020 21:55

YulNaumenko self-assigned this Mar 18, 2020

pmuellr requested changes Mar 19, 2020

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx Outdated Show resolved Hide resolved

Fixed due to comments

198ca72

YulNaumenko requested a review from pmuellr March 19, 2020 17:15

mikecote reviewed Mar 19, 2020

View reviewed changes

pmuellr approved these changes Mar 19, 2020

View reviewed changes

Fixed additional request for the last field

4206b7d

YulNaumenko requested a review from mikecote March 20, 2020 01:49

Fixed failing test

92609c3

mikecote approved these changes Mar 20, 2020

View reviewed changes

YulNaumenko merged commit 64e09af into elastic:master Mar 20, 2020

YulNaumenko mentioned this pull request Mar 20, 2020

[7.x] Implemented ability to clear and properly validate alert interval (#60571) #60755

Closed

YulNaumenko mentioned this pull request Mar 20, 2020

[7.x] Implemented ability to clear and properly validate alert interval (#60571) #60778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented ability to clear and properly validate alert interval #60571

Implemented ability to clear and properly validate alert interval #60571

YulNaumenko commented Mar 18, 2020

elasticmachine commented Mar 18, 2020

pmuellr left a comment •

edited

Loading

mikecote left a comment

pmuellr left a comment

kibanamachine commented Mar 20, 2020

Standard Out

Stack Trace

mikecote left a comment

Implemented ability to clear and properly validate alert interval #60571

Implemented ability to clear and properly validate alert interval #60571

Conversation

YulNaumenko commented Mar 18, 2020

elasticmachine commented Mar 18, 2020

pmuellr left a comment • edited Loading

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

pmuellr left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 20, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

mikecote left a comment

Choose a reason for hiding this comment

pmuellr left a comment •

edited

Loading