Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again #60380

Merged
merged 2 commits into from
Mar 17, 2020
Merged

[SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again #60380

merged 2 commits into from
Mar 17, 2020

Conversation

MadameSheema
Copy link
Member

Summary

This PR revert the changes of the revert of the #60064 PR.

We started to experience some failures in Jenkins for 'Closes and opens signals' test of the Detections spec. By mistake the changes of the 'Closes one signal when more than one opened signals are selected' test were reverted.

As during the day no more failures have been detected for the flaky test:

  • We are going to revert the revert of the [SIEM] Adds 'Close one signal' Cypress test #60064 PR in order to have the test again in master.
  • We are not going to skip the 'Closes and opens signals' test for now.
  • For the 'Closes and opens signals' test we are adding an extra check were the test was failing before. As we are preloading the signals using es_archiver we now that we are going to have more than 25 signals. 25 is the number of default signals that are displayed, so we are going to wait to have it displayed in the screen before performing any action and is going to timeout after 30 seconds.

@MadameSheema MadameSheema added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 17, 2020
@MadameSheema MadameSheema requested a review from spalger March 17, 2020 14:47
@MadameSheema MadameSheema self-assigned this Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

spalger
spalger approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

yctercero
yctercero approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for the tests!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit 79b0454 into elastic:master Mar 17, 2020
@MadameSheema MadameSheema deleted the revert-close-one-signal branch March 17, 2020 17:14
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Mar 17, 2020
@MadameSheema
[SIEM] Adds 'Closes one signal when more than one opened signals are …
63b339a 
…selected' test again (elastic#60380)

* Revert "Revert "adds new test (elastic#60064)""

This reverts commit 4a8fd0a.

* waits for having 25 signals displayed
@MadameSheema MadameSheema mentioned this pull request Mar 17, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
08c05b6 
* master:
  [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380)
  [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108)
  [Fleet] Add config revision to fleet agents (elastic#60292)
  Allow kbn-config-schema to ignore unknown keys (elastic#59560)
  [ML] Functional tests - disable df analytics clone tests
  skip flaky suite (elastic#58643) (elastic#58991)
  [FTR] Add support for --include and --exclude files via tags (elastic#60123)
  [SIEM] Fix link on overview page (elastic#60348)
  skip flaky test (elastic#60369)
  [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242)
  [Lens] Simplify state management from visualization (elastic#58279)
  Changing default type to start and allowing it to be configured by the event category (elastic#60323)
  [ML] Adds the class_assignment_objective to classification (elastic#60358)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
3c7bea5 
* master: (51 commits)
  do not update cell background if is label cell (elastic#60308)
  FTR configurable test users (elastic#52431)
  [Reporting] Wholesale moves client to newest-platform (elastic#58945)
  [Ingest] Support `show_user` package registry flag (elastic#60338)
  [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380)
  [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108)
  [Fleet] Add config revision to fleet agents (elastic#60292)
  Allow kbn-config-schema to ignore unknown keys (elastic#59560)
  [ML] Functional tests - disable df analytics clone tests
  skip flaky suite (elastic#58643) (elastic#58991)
  [FTR] Add support for --include and --exclude files via tags (elastic#60123)
  [SIEM] Fix link on overview page (elastic#60348)
  skip flaky test (elastic#60369)
  [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242)
  [Lens] Simplify state management from visualization (elastic#58279)
  Changing default type to start and allowing it to be configured by the event category (elastic#60323)
  [ML] Adds the class_assignment_objective to classification (elastic#60358)
  [TSVB] fix text color when using custom background color (elastic#60261)
  Fix import to timefilter from in TSVB (elastic#60296)
  [NP] Get rid of usage redirectWhenMissing service (elastic#59777)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
@gmmorris
Merge branch 'alerting/view-in-app' into alerting/api-constant
1ddeae4 
* alerting/view-in-app: (53 commits)
  fixed typo
  handle optional alerting plugin
  do not update cell background if is label cell (elastic#60308)
  FTR configurable test users (elastic#52431)
  [Reporting] Wholesale moves client to newest-platform (elastic#58945)
  [Ingest] Support `show_user` package registry flag (elastic#60338)
  [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380)
  [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108)
  [Fleet] Add config revision to fleet agents (elastic#60292)
  Allow kbn-config-schema to ignore unknown keys (elastic#59560)
  [ML] Functional tests - disable df analytics clone tests
  skip flaky suite (elastic#58643) (elastic#58991)
  [FTR] Add support for --include and --exclude files via tags (elastic#60123)
  [SIEM] Fix link on overview page (elastic#60348)
  skip flaky test (elastic#60369)
  [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242)
  [Lens] Simplify state management from visualization (elastic#58279)
  Changing default type to start and allowing it to be configured by the event category (elastic#60323)
  [ML] Adds the class_assignment_objective to classification (elastic#60358)
  [TSVB] fix text color when using custom background color (elastic#60261)
  ...
MadameSheema added a commit that referenced this pull request Mar 18, 2020
@MadameSheema @elasticmachine
[SIEM] Adds 'Closes one signal when more than one opened signals are …
b9e4e6e 
…selected' test again (#60380) (#60417)

* Revert "Revert "adds new test (#60064)""

This reverts commit 4a8fd0a.

* waits for having 25 signals displayed

Co-authored-by: Elastic Machine <[email protected]>
@MadameSheema MadameSheema mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

@spalger spalger spalger approved these changes

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibanamachine @spalger @yctercero