[kbn/pm] don't fail when plugins are outside repo #60164
Conversation
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
| @@ -48,6 +48,7 @@ | |||
| "globby": "^8.0.1", | |||
| "has-ansi": "^3.0.0", | |||
| "indent-string": "^3.2.0", | |||
| "is-path-inside": "^3.0.2", | |||
There was a problem hiding this comment.
Is a dependency really necessary to test if a path starts with another path?
There was a problem hiding this comment.
Sorry, didn't see this before merge. It's not necessary but it covers some edge cases, is already installed (checkout the changes to yarn.lock) and isn't included in the front end so I didn't see any harm in it.
There was a problem hiding this comment.
It's also hyper focused so it would be really easy to rip out, and will be really easy to upgrade. It is the best kind of dependency if you ask me.
There was a problem hiding this comment.
That's fair. Though looks like the only edge case is with 32bit Windows which we don't support.
This really should be part path or something in core utils.
* [kbn/pm] don't fail when plugins are outside repo * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* master: [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) Update ingest management team handle (elastic#60457) [IM] Use EuiCodeBlock to render index mapping (elastic#60420) Add additional safeguards for data source wizard step 2 (elastic#60426) [kbn/pm] don't fail when plugins are outside repo (elastic#60164) upgrade react-use (elastic#60427) Remove link to old settings (elastic#60326) Update app arch CODEOWNERS items. (elastic#60396) [ML] Fixing custom urls to dashboards (elastic#60355) Update the ems-client dependency to 7.7.0 (elastic#59936)
* [kbn/pm] don't fail when plugins are outside repo * remove unused import Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: spalger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
|
7.x/7.7: 719dbe7 |
Fixes #59931 (comment)
When we added the bootstrap cache in #53622 we didn't verify that it continued to work when people have plugins that are outside of the repo (in kibana-extra directories for instance). These projects are still picked up by
@kbn/pm, and so they need to be handled properly by the bootstrap cache generation logic. Thankfully the logic already has conditions in place for when the cache key can't be generated for whatever reason, and this is just an extension of that which prevents passing paths to git which would cause it to fail.