Migrate test plugins ⇒ NP (kbn_tp_top_nav) #60092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
reviewed
Mar 13, 2020
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
@lizozom just want to know your opinion. should we provide tsconfig.json and package.json for test/plugin_functional/plugins/** plugins?
it looks a little odd to me
There was a problem hiding this comment.
Well, if things work without them, I guess no :) @alexwizp
alexwizp
reviewed
Mar 13, 2020
| public setup(core: CoreSetup, { navigation }: { navigation: NavigationPublicPluginSetup }) { | ||
| const customExtension = { | ||
| id: 'registered-prop', | ||
| label: 'Registered Button', |
There was a problem hiding this comment.
From my point of view all static string values should be localized
|
@elasticmachine merge upstream |
alexwizp
changed the title
|
@elasticmachine merge upstream |
VladLasitsa
added
Feature:NP Migration
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@lizozom could you please have a look |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Mar 30, 2020
* Migrated top nav plugin test to the new platform * Removed old plugin. Some refactoring. Co-authored-by: Elastic Machine <[email protected]>
VladLasitsa
added a commit
that referenced
this pull request
Mar 31, 2020
* Migrated top nav plugin test to the new platform * Removed old plugin. Some refactoring. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #51275
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers