-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [CASES] Status / Batch update #59856
Conversation
…o status + allow batch update for cases
Pinging @elastic/siem (Team:SIEM) |
This is awesome @XavierM. You even added some new tests, hooray! I performed a code review, endpoint testing, and UI testing. I only came up with a couple of UI issues listed below. I published my Postman API docs with the endpoints and curl calls. We should make a new PR that has curl scripts like the detection engine for testing. https://documenter.getpostman.com/view/172706/SW7c2SuF?version=latest While I was hard strapped to find issues with the code, I did find a couple of bugs in the UI. The first one is my fault and I can fix in a follow up PR. I'm sure it was like this before and I didn't notice... but when we add a comment, we probably should refetch the whole case instead of appending the comment to the list, because the case version number isn't getting updated resulting in this bug. The other one is the case count in the header isn't getting updated when a case is closed in the table. This one I put on you, although I am happy to help fix or to fix it myself in a new PR. Let me know what you think and I'm just about ready to LGTM :) |
Let me fix them, so it is over!!! |
@stephmilovic Like we discussed in the next PR we are going to move the comment in the case saved object. So I do not think we should take the time to fix it now. But for sure in the next PR I will make sure that we are good. please let me know |
x-pack/legacy/plugins/siem/public/containers/case/use_get_reporters.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/columns.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as usual @XavierM, LGTM 🚀 🎸
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* add global status count + add status count with find + rename state to status + allow batch update for cases * fix all my bug and integrate API with UI * add reporters functionality * review II * review III Co-authored-by: Elastic Machine <[email protected]>
* add global status count + add status count with find + rename state to status + allow batch update for cases * fix all my bug and integrate API with UI * add reporters functionality * review II * review III Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Cases API works:
Checklist
Delete any items that are not applicable to this PR.
For maintainers