Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Re-enable logstash tests #59815

Merged
merged 6 commits into from
Mar 12, 2020
Merged

[Monitoring] Re-enable logstash tests #59815

merged 6 commits into from
Mar 12, 2020

Conversation

chrisronline
Copy link
Contributor

Re-enables tests skipped in #52740

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 10, 2020
@chrisronline chrisronline requested a review from a team March 10, 2020 19:07
@chrisronline chrisronline self-assigned this Mar 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic
igoristic approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the CI passes 👍

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 73d1013 into elastic:master Mar 12, 2020
@chrisronline chrisronline deleted the monitoring/reenable_tests branch March 12, 2020 18:21
@chrisronline chrisronline mentioned this pull request Mar 12, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
62c10f8 
* master:
  Endpoint: Change the input type for @kbn/config-schema to work with more schemas (elastic#60007)
  Using re2 for Timelion regular expressions (elastic#55208)
  [Monitoring] Re-enable logstash tests (elastic#59815)
  fix karma debug typo (elastic#60029)
  Adds telemetry support to alerting and actions plugins (elastic#58081)
chrisronline added a commit that referenced this pull request Mar 12, 2020
@chrisronline @elasticmachine
[Monitoring] Re-enable logstash tests (#59815) (#60051)
3b588c5 
* Revert "Skip all logstash pipeline tests"

This reverts commit d8aa1fb.

* Reenable tests and fix them based on recent changes

* Fix more tests

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@chrisronline
Copy link
Contributor Author

Backport:

7.x: 3b588c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic