Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transforms: Replace KqlFilterBar with QueryStringInput. #59723

Merged
merged 7 commits into from
Mar 12, 2020
Merged

[ML] Transforms: Replace KqlFilterBar with QueryStringInput. #59723

merged 7 commits into from
Mar 12, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 10, 2020 •
edited
Loading

Summary

  • Replaces the custom KqlFilterBar with Kibana's QueryStringInput. This means the wizard now supports both lucene and kuery input.
  • Using this component we no longer need to do cross-imports from the ML plugin. The use of setDependencyCache is no longer necessary.
  • Replaces the custom AppDependencies provider code with Kibana's KibanaContextProvider.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@walterra walterra self-assigned this Mar 10, 2020
@walterra walterra force-pushed the ml-transforms-query-string-input branch from 8693f9b to 661e81f Compare March 10, 2020 15:25
@walterra walterra force-pushed the ml-transforms-query-string-input branch from cf458c3 to 9fa3c4b Compare March 12, 2020 07:51
@walterra walterra marked this pull request as ready for review March 12, 2020 08:12
@walterra walterra requested a review from a team as a code owner March 12, 2020 08:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

peteharverson
peteharverson approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Is there any quick styling fix for the overflow here:

image

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_discover_navigation·js.context app context link in discover should open the context view with the selected document as anchor

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/53308

[00:00:00]       │
[00:00:13]         └-: context app
[00:00:13]           └-> "before all" hook
[00:00:13]           └-> "before all" hook
[00:00:13]             │ info [logstash_functional] Loading "mappings.json"
[00:00:13]             │ info [logstash_functional] Loading "data.json.gz"
[00:00:13]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]]).
[00:00:13]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:13]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:13]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]]).
[00:00:13]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:13]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:13]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:13]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]]).
[00:00:13]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:13]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:23]             │ info progress: 9928
[00:00:26]             │ info [logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:00:26]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:26]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:00:27]             │ info [visualize] Loading "mappings.json"
[00:00:27]             │ info [visualize] Loading "data.json"
[00:00:27]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_1/nUu54j-nRqSU0_WWRQ0NTw] deleting index
[00:00:27]             │ info [visualize] Deleted existing index [".kibana_1"]
[00:00:27]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:27]             │ info [visualize] Created index ".kibana"
[00:00:27]             │ debg [visualize] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:00:27]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana/bZHw_dH7SDqY9SGAg9UdxA] update_mapping [_doc]
[00:00:27]             │ info [visualize] Indexed 7 docs into ".kibana"
[00:00:27]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana/bZHw_dH7SDqY9SGAg9UdxA] update_mapping [_doc]
[00:00:27]             │ debg Migrating saved objects
[00:00:27]             │ proc [kibana]   log   [13:20:14.486] [info][savedobjects-service] Creating index .kibana_2.
[00:00:27]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:27]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:27]             │ proc [kibana]   log   [13:20:14.604] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:00:27]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:00:27]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:28]             │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1], mappings [_doc]
[00:00:28]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] updating number_of_replicas to [0] for indices [.tasks]
[00:00:28]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] 868 finished with response BulkByScrollResponse[took=93.5ms,timed_out=false,sliceId=null,updated=0,created=7,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:28]             │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana/bZHw_dH7SDqY9SGAg9UdxA] deleting index
[00:00:28]             │ proc [kibana]   log   [13:20:15.093] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:28]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_2/pCR-7FzuQ8y0wWcYgU0azQ] update_mapping [_doc]
[00:00:28]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_2/pCR-7FzuQ8y0wWcYgU0azQ] update_mapping [_doc]
[00:00:28]             │ proc [kibana]   log   [13:20:15.283] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:28]             │ proc [kibana]   log   [13:20:15.355] [info][savedobjects-service] Finished in 873ms.
[00:00:28]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:28]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_2/pCR-7FzuQ8y0wWcYgU0azQ] update_mapping [_doc]
[00:00:29]             │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:00:30]             │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1584018082707284851] [.kibana_2/pCR-7FzuQ8y0wWcYgU0azQ] update_mapping [_doc]
[00:00:30]             │ debg navigating to discover url: http://localhost:6111/app/kibana#/discover
[00:00:30]             │ debg Navigate to: http://localhost:6111/app/kibana#/discover
[00:00:31]             │ debg ... sleep(700) start
[00:00:31]             │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1584019217628#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:31]             │
[00:00:31]             │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:31]             │ debg ... sleep(700) end
[00:00:31]             │ debg returned from get, calling refresh
[00:00:31]             │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1584019217628#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:32]             │
[00:00:32]             │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:32]             │ debg currentUrl = http://localhost:6111/app/kibana#/discover
[00:00:32]             │          appUrl = http://localhost:6111/app/kibana#/discover
[00:00:32]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:33]             │ debg TestSubjects.find(kibanaChrome)
[00:00:33]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:00:33]             │ debg browser[INFO] http://localhost:6111/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-12T13:20:19Z
[00:00:33]             │        Adding connection to http://localhost:6111/elasticsearch
[00:00:33]             │
[00:00:33]             │      "
[00:00:33]             │ debg ... sleep(501) start
[00:00:34]             │ debg ... sleep(501) end
[00:00:34]             │ debg in navigateTo url = http://localhost:6111/app/kibana#/discover
[00:00:34]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:34]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:36]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:37]           └-: context link in discover
[00:00:37]             └-> "before all" hook
[00:00:37]             └-> "before all" hook
[00:00:37]               │ debg navigating to discover url: http://localhost:6111/app/kibana#/discover
[00:00:37]               │ debg Navigate to: http://localhost:6111/app/kibana#/discover
[00:00:37]               │ debg ... sleep(700) start
[00:00:37]               │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1584019224031#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:37]               │
[00:00:37]               │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:38]               │ debg ... sleep(700) end
[00:00:38]               │ debg returned from get, calling refresh
[00:00:38]               │ debg browser[INFO] http://localhost:6111/app/kibana?_t=1584019224031#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:38]               │
[00:00:38]               │ debg browser[INFO] http://localhost:6111/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:38]               │ debg currentUrl = http://localhost:6111/app/kibana#/discover
[00:00:38]               │          appUrl = http://localhost:6111/app/kibana#/discover
[00:00:38]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:40]               │ debg TestSubjects.find(kibanaChrome)
[00:00:40]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:00:40]               │ debg browser[INFO] http://localhost:6111/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-12T13:20:26Z
[00:00:40]               │        Adding connection to http://localhost:6111/elasticsearch
[00:00:40]               │
[00:00:40]               │      "
[00:00:40]               │ debg ... sleep(501) start
[00:00:41]               │ debg ... sleep(501) end
[00:00:41]               │ debg in navigateTo url = http://localhost:6111/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:41]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:00:41]               │ debg ... sleep(501) start
[00:00:42]               │ debg ... sleep(501) end
[00:00:42]               │ debg in navigateTo url = http://localhost:6111/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:00:42]               │ debg TestSubjects.exists(statusPageContainer)
[00:00:42]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:44]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:45]               │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:00:45]               │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:00:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:00:45]               │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:00:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:00:45]               │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:00:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:00:45]               │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:00:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:00:45]               │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:00:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:00:45]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:00:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:00:45]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:00:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:45]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:00:45]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:00:45]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:45]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:46]               │ debg ... sleep(500) start
[00:00:46]               │ debg ... sleep(500) end
[00:00:46]               │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:00:46]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:00:46]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:00:47]               │ debg Find.waitForElementStale with timeout=10000
[00:00:47]               │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:00:47]               │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:00:47]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:00:47]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:00:47]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:00:47]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:47]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:47]               │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:00:47]               │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:00:47]               │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:47]               │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:00:48]               │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:00:48]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:00:51]               │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:00:51]               │ debg TestSubjects.click(querySubmitButton)
[00:00:51]               │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:00:51]               │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:00:51]               │ debg Find.waitForElementStale with timeout=10000
[00:00:52]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:52]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:54]               │ debg TestSubjects.moveMouseTo(field-@message)
[00:00:54]               │ debg TestSubjects.find(field-@message)
[00:00:54]               │ debg Find.findByCssSelector('[data-test-subj="field-@message"]') with timeout=10000
[00:00:55]               │ debg TestSubjects.click(fieldToggle-@message)
[00:00:55]               │ debg Find.clickByCssSelector('[data-test-subj="fieldToggle-@message"]') with timeout=10000
[00:00:55]               │ debg Find.findByCssSelector('[data-test-subj="fieldToggle-@message"]') with timeout=10000
[00:00:56]               │ debg TestSubjects.click(field-extension)
[00:00:56]               │ debg Find.clickByCssSelector('[data-test-subj="field-extension"]') with timeout=10000
[00:00:56]               │ debg Find.findByCssSelector('[data-test-subj="field-extension"]') with timeout=10000
[00:00:56]               │ debg Find.clickByCssSelector('[data-test-subj="plus-extension-jpg"]') with timeout=10000
[00:00:56]               │ debg Find.findByCssSelector('[data-test-subj="plus-extension-jpg"]') with timeout=10000
[00:00:57]               │ debg isGlobalLoadingIndicatorVisible
[00:00:57]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:57]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:57]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:57]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:57]               │ debg TestSubjects.click(field-geo.src)
[00:00:57]               │ debg Find.clickByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:00:57]               │ debg Find.clickByCssSelector('[data-test-subj="plus-geo.src-IN"]') with timeout=10000
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="plus-geo.src-IN"]') with timeout=10000
[00:00:57]               │ debg isGlobalLoadingIndicatorVisible
[00:00:57]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:57]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:57]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:57]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:57]             └-> should open the context view with the selected document as anchor
[00:00:57]               └-> "before each" hook: global before each
[00:00:57]               │ debg TestSubjects.find(docTable)
[00:00:57]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:00:58]               │ debg TestSubjects.find(docTable)
[00:00:58]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:00:58]               │ debg TestSubjects.find(docTable)
[00:00:58]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:01:09]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/context app context link in discover should open the context view with the selected document as anchor.png"
[00:01:09]               │ info Current URL is: http://localhost:6111/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(%27@message%27),filters:!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,index:%27logstash-*%27,key:extension,negate:!f,params:(query:jpg),type:phrase),query:(match_phrase:(extension:jpg))),(%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,index:%27logstash-*%27,key:geo.src,negate:!f,params:(query:IN),type:phrase),query:(match_phrase:(geo.src:IN)))),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:01:09]               │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/context app context link in discover should open the context view with the selected document as anchor.html
[00:01:09]               └- ✖ fail: "context app context link in discover should open the context view with the selected document as anchor"
[00:01:09]               │

Stack Trace

TypeError: Cannot read property 'click' of undefined
    at Context.<anonymous> (test/functional/apps/context/_discover_navigation.js:54:64)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit 1ede10c into elastic:master Mar 12, 2020
@walterra walterra deleted the ml-transforms-query-string-input branch March 12, 2020 14:55
walterra added a commit to walterra/kibana that referenced this pull request Mar 12, 2020
@walterra
[ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic…
8ec101f 
…#59723)

- Replaces the custom KqlFilterBar with Kibana's QueryStringInput. This means the wizard now supports both lucene and kuery input.
- Using this component we no longer need to do cross-imports from the ML plugin. The use of setDependencyCache is no longer necessary.
- Replaces the custom AppDependencies provider code with Kibana's KibanaContextProvider.
@walterra walterra mentioned this pull request Mar 12, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
fc5b17c 
* master: (45 commits)
  skip flaky suite (elastic#59717)
  UI Metrics use findAll to retrieve all Saved Objects (elastic#59891)
  [Discover] Migrate Context mocha tests to use Jest (elastic#59658)
  [Maps] Move redux reducers and store logic to NP (elastic#58294)
  rebalance x-pack groups (elastic#58930)
  [Discover] Reimplement $route.reload when index pattern changes (elastic#59877)
  [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745)
  Skip CI based on changes in PR (elastic#59939)
  [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723)
  [ML] Functional tests - stabilize date_nanos test (elastic#59986)
  [ML] Typescripting client side endpoint functions (elastic#59928)
  a11y tests on adding columns to discover table (elastic#59375)
  fix graph plugin config path (elastic#59540)
  fix vega config issues (elastic#59737)
  [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890)
  [ML] Adding shared services to ml setup contract (elastic#59730)
  [Visualize] Fix linked search behavior (elastic#59690)
  [ML] Register NP ML plugin for Kibana management section. (elastic#59762)
  [Lens] Adds using queries/filters for field existence endpoint (elastic#59033)
  Delete FilterStateManager and QueryFilter :-D (elastic#59872)
  ...
walterra added a commit that referenced this pull request Mar 13, 2020
@walterra
[ML] Transforms: Replace KqlFilterBar with QueryStringInput. (#59723) (…
6b6a7b6 
…#60012)

- Replaces the custom KqlFilterBar with Kibana's QueryStringInput. This means the wizard now supports both lucene and kuery input.
- Using this component we no longer need to do cross-imports from the ML plugin. The use of setDependencyCache is no longer necessary.
- Replaces the custom AppDependencies provider code with Kibana's KibanaContextProvider.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@walterra walterra

Labels
Feature:Transforms ML transforms :ml refactoring release_note:enhancement v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson