-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM]Create custom link from Trace summary #59648
[APM]Create custom link from Trace summary #59648
Conversation
1db124d
to
921d7e6
Compare
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Show resolved
Hide resolved
...k/legacy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/LicensePrompt.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/settings/custom_link/create_custom_link_index.ts
Outdated
Show resolved
Hide resolved
...plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/helper.ts
Outdated
Show resolved
Hide resolved
ff13d7a
to
7729021
Compare
...pm/public/components/app/Settings/CustomizeUI/CustomLink/CustomLinkFlyout/FiltersSection.tsx
Outdated
Show resolved
Hide resolved
7cadbd8
to
8d4ad08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor visual nits on the popover
.../plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkPopover.tsx
Show resolved
Hide resolved
.../plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/CustomLinkPopover.tsx
Show resolved
Hide resolved
...y/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/ManageCustomLink.tsx
Show resolved
Hide resolved
...ugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/CustomLink.test.tsx
Show resolved
Hide resolved
...cy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/helper.test.ts
Outdated
Show resolved
Hide resolved
...ugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/CustomLink.test.tsx
Outdated
Show resolved
Hide resolved
...cy/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/__test__/helper.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/shared/LicensePrompt/index.tsx
Show resolved
Hide resolved
retest |
@cauemarcondes spotted the CI error from the ML job cloning test on this PR. If you haven't done so already, you probably want to rebase against master as we disabled this test yesterday whilst we work on a stability fix for the failing test. |
Thanks @peteharverson will do it. |
db206d1
to
a628b31
Compare
x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/shared/TransactionActionMenu/CustomLink/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/server/lib/settings/custom_link/create_custom_link_index.ts
Show resolved
Hide resolved
72acd05
to
6c9c8fc
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_listing·js.dashboard app using legacy data dashboard listing page search does not match mid wordStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
* master: (39 commits) [APM]Create custom link from Trace summary (elastic#59648) [ML] Fixing app clean up (elastic#60853) [SIEM] Use ECS categorisation for Authentication widgets (elastic#60734) [NP] Remove kbnUrl usage in discover/dashboard/visualize (elastic#60016) Skip failing test [Uptime]Update fetch effect failed action handling (elastic#60742) [npm] upgrade elastic/maki (elastic#60829) [Uptime] Add Settings Page (elastic#53550) [APM] service maps: avoid unnecesary `useDeepObjectIdentity` (elastic#60836) [Index management] Re-enable index template tests (elastic#60780) Fixed UI/UX issues: alerts delete confirmation, combobox behaviors (elastic#60703) [SIEM] Fix patching of ML Rules (elastic#60830) [APM] Service Map - Separate overlapping edges by rotating nodes (elastic#60477) [Alerting] fix flaky test for index threshold grouping (elastic#60792) [SIEM][Detection Engine] Adds test scripts for machine learning feature Flatten child api response for resolver (elastic#60810) Change "url" to "urls" in APM agent instructions (elastic#60790) [DOCS] Updates API requests and examples (elastic#60695) [SIEM] [Cases] Create case from timeline (elastic#60711) [Lens] Resetting a layer generates new suggestions (elastic#60674) ...
* adding custom links to actions menu * user should have at least gold license to be able to manage custom links * replacing variable for the correspondent value * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * adding unit test, splitting value by comma and removing empty ones * adding custom links to actions menu * UI fixes * moving stuff to common * changing flyout texts * refactoring getSelectOption * refactoring getSelectOption * refactoring filter options name * adding preview panel * adding preview panel * fixing test * adding unit test for replace template variables * fixing typo * polishing preview panel * fixing pr comments * fixing pr comments * adding links * fixing unit test * removing servicemap license prompt
* adding custom links to actions menu * user should have at least gold license to be able to manage custom links * replacing variable for the correspondent value * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * refactoring license prompt to a shared place * fixing query to return filters that were saved separated by comma * adding unit test, splitting value by comma and removing empty ones * adding custom links to actions menu * UI fixes * moving stuff to common * changing flyout texts * refactoring getSelectOption * refactoring getSelectOption * refactoring filter options name * adding preview panel * adding preview panel * fixing test * adding unit test for replace template variables * fixing typo * polishing preview panel * fixing pr comments * fixing pr comments * adding links * fixing unit test * removing servicemap license prompt
closes #57783
closes #58923
closes #59780
closes #58110
Show custom links in the Actions menu, with a
create
andmanage
buttons. The first three links will be shown in the first popover and the remaining after the user pushes theSee more
button.