Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drilldowns #59632

Merged
merged 109 commits into from
Mar 24, 2020
Merged

Drilldowns #59632

merged 109 commits into from
Mar 24, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Mar 9, 2020 •
edited
Loading

Summary

Partially addresses #42845
Closes #59973

This PR adds initial drilldowns feature to Kibana.

Drilldowns are hidden behind a feature flag, to enable add to your kibana.yml:

xpack.dashboardEnhanced.drilldowns.enabled: true

After merging this PR we need to also merge Dashboard-to-Dashboard and functional test PR: #60087

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Dosant and others added 2 commits March 9, 2020 09:57
@Dosant
Add drilldown wizard components
502a60a
@streamich @mattkime @elasticmachine
Dynamic actions (#58216)
a7ed6ab 
* feat: 🎸 add DynamicAction and FactoryAction types

* feat: 🎸 add Mutable<T> type to @kbn/utility-types

* feat: 🎸 add ActionInternal and ActionContract

* chore: 🤖 remove unused file

* feat: 🎸 improve action interfaces

* docs: ✏️ add JSDocs

* feat: 🎸 simplify ui_actions interfaces

* fix: 🐛 fix TypeScript types

* feat: 🎸 add AbstractPresentable interface

* feat: 🎸 add AbstractConfigurable interface

* feat: 🎸 use AbstractPresentable in ActionInternal

* test: 💍 fix ui_actions Jest tests

* feat: 🎸 add state container to action

* perf: ⚡️ convert MenuItem to React component on Action instance

* refactor: 💡 rename AbsractPresentable -> Presentable

* refactor: 💡 rename AbstractConfigurable -> Configurable

* feat: 🎸 add Storybook to ui_actions

* feat: 🎸 add <ErrorConfigureAction> component

* feat: 🎸 improve <ConfigureAction> component

* chore: 🤖 use .story file extension prefix for Storybook

* feat: 🎸 improve <ErrorConfigureAction> component

* feat: 🎸 show error if dynamic action has CollectConfig missing

* feat: 🎸 render sample action configuration component

* feat: 🎸 connect action config to <ConfigureAction>

* feat: 🎸 improve <ConfigureAction> stories

* test: 💍 add ActionInternal serialize/deserialize tests

* feat: 🎸 add ActionContract

* feat: 🎸 split action Context into Execution and Presentation

* fix: 🐛 fix TypeScript error

* refactor: 💡 extract state container hooks to module scope

* docs: ✏️ fix typos

* chore: 🤖 remove Mutable<t> type

* test: 💍 don't cast to any getActions() function

* style: 💄 avoid using unnecessary types

* chore: 🤖 address PR review comments

* chore: 🤖 rename ActionContext generic

* chore: 🤖 remove order from state container

* chore: 🤖 remove deprecation notice on getHref

* test: 💍 fix tests after order field change

* remove comments

Co-authored-by: Matt Kime <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@streamich streamich requested review from a team as code owners March 9, 2020 09:31
@botelastic botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Mar 9, 2020
streamich and others added 2 commits March 9, 2020 12:09
@streamich
Drilldown context menu (#59638)
43583c2 
* fix: 🐛 fix TypeScript error

* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger

* fix: 🐛 correctly order context menu items

* fix: 🐛 set correct order on drilldown flyout actions

* fix: 🐛 clean up context menu building functions

* feat: 🎸 add context menu separator action
@Dosant
Add basic ActionFactoryService. Pass data from it into components ins…
e145241 
…tead of mocks
@Dosant Dosant self-requested a review March 9, 2020 11:59
@Dosant Dosant changed the title Drilldowns [wip] Drilldowns Mar 9, 2020
@Dosant Dosant added the WIP Work in progress label Mar 9, 2020
streamich and others added 5 commits March 9, 2020 14:46
@streamich
Dashboard x pack (#59653)
81e6bcb 
* feat: 🎸 add dashboard_enhanced plugin to x-pack

* feat: 🎸 improve context menu separator

* feat: 🎸 move drilldown flyout actions to dashboard_enhanced

* fix: 🐛 fix exports from ui_actions plugin
@streamich
feat: 🎸 "implement" registerDrilldown() method
1f2cc4c
@Dosant
fix ConfigurableBaseConfig type
86885c4
@Dosant
Implement connected flyout_manage_drilldowns component
6463118
@Dosant
Merge branch 'master' of github.com:elastic/kibana into drilldowns
dcacf10
@Dosant Dosant mentioned this pull request Mar 10, 2020
Closed
7 tasks
@streamich
Copy link
Contributor Author

retest

@streamich streamich changed the title [wip] Drilldowns Drilldowns Mar 10, 2020
@Dosant
Connect welcome message to storage
f057979 
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
@Dosant Dosant removed their request for review March 10, 2020 13:52
andreadelrio
andreadelrio approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdefazio
mdefazio approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@streamich streamich requested a review from ppisljar March 23, 2020 17:22
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover
joshdover approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think you to regenerate the docs based on the API change to flyouts.

kertal
kertal approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners files LGTM, didn't test

@streamich streamich merged commit 5abb2c8 into master Mar 24, 2020
@streamich streamich mentioned this pull request Mar 24, 2020
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 24, 2020
@gmmorris
Merge branch 'master' into alerting/tls-warning
1b3d0b4 
* master: (34 commits)
  [APM] add service map config options to legacy plugin (elastic#61002)
  [App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) (elastic#59882)
  Migrated styles for "share" plugin to new platform (elastic#59981)
  [ML] Module setup with dynamic model memory estimation (elastic#60656)
  Drilldowns (elastic#59632)
  Upgrade mocha dev-dependency from 6.2.2 to 7.1.1 (elastic#60779)
  [SIEM] Overview: Recent cases widget (elastic#60993)
  [ML] Functional tests - stabilize df analytics clone tests (elastic#60497)
  [SIEM] Updates process and TLS tables to use ECS 1.5 fields (elastic#60854)
  Migrate doc view part of discover (elastic#58094)
  Revert "[APM] Collect telemetry about data/API performance (elastic#51612)"
  fix(NA): log rotation watchers usage (elastic#60956)
  [SIEM] [CASES] Build lego blocks case details view (elastic#60864)
  Create Painless Lab app (elastic#57538)
  [SIEM] Move Timeline Template field to first step of rule creation (elastic#60840)
  [Reporting/New Platform Migration] Use a new config service on server-side (elastic#55882)
  [Alerting] allow email action to not require auth (elastic#60839)
  [Maps] Default ES document layer scaling type to clusters and show scaling UI in the create wizard (elastic#60668)
  [APM] Collect telemetry about data/API performance (elastic#51612)
  Implement Kibana Login Selector (elastic#53010)
  ...
mattkime added a commit to mattkime/kibana that referenced this pull request Mar 24, 2020
@mattkime
Revert "Drilldowns (elastic#59632)"
50a4037 
This reverts commit 5abb2c8.
@mattkime mattkime mentioned this pull request Mar 24, 2020
Merged
mattkime added a commit that referenced this pull request Mar 24, 2020
@mattkime
Revert "Drilldowns (#59632)" (#61136)
498abb4 
This reverts commit 5abb2c8.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59632 or prevent reminders by adding the backport:skip label.

@streamich streamich added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 26, 2020
@mattkime mattkime removed the v7.7.0 label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

@ppisljar ppisljar ppisljar approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

@mdefazio mdefazio mdefazio approved these changes

@jbudz jbudz jbudz approved these changes

@joshdover joshdover joshdover approved these changes

@kertal kertal kertal approved these changes

@mattkime mattkime Awaiting requested review from mattkime

@Dosant Dosant Awaiting requested review from Dosant

@lizozom lizozom Awaiting requested review from lizozom

Assignees

@mattkime mattkime

@Dosant Dosant

@streamich streamich

Labels
backport:skip This commit does not require backporting Feature:Drilldowns Embeddable panel Drilldowns reverted review v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalize drilldowns 🎉