[SIEM] [Cases] Delete, comment, and reducer updates #59616
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ export interface Comment { | |
| export interface Case { | ||
| id: string; | ||
| comments: Comment[]; | ||
| commentIds: string[]; | ||
|
There was a problem hiding this comment. Why we need the comment ids in a different array? Aren't included in comments array? There was a problem hiding this comment. @XavierM had reasons There was a problem hiding this comment. @cnasikas, you will only get the comments through the API if you set the query parameter There was a problem hiding this comment. @XavierM Sorry to insist, but if this is the only use case why the API does not return the count of the comments? Do you think there will be another use case in the future where ids will be needed? There was a problem hiding this comment. I agree with you but since we do not have aggregation on the saved object I did that to avoid query every comment for every case. Might not be the most robust way of doing it. However, it will be faster. When we have aggregation in saved_object, we will be able to use that to just get the count like you said |
||
| createdAt: string; | ||
| createdBy: ElasticUser; | ||
| description: string; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import { useCallback, useReducer } from 'react'; | ||
| import { errorToToaster } from '../../components/ml/api/error_to_toaster'; | ||
| import * as i18n from './translations'; | ||
| import { useStateToaster } from '../../components/toasters'; | ||
| import { deleteCases } from './api'; | ||
|
|
||
| interface DeleteState { | ||
| isDisplayConfirmDeleteModal: boolean; | ||
| isDeleted: boolean; | ||
| isLoading: boolean; | ||
| isError: boolean; | ||
| } | ||
| type Action = | ||
| | { type: 'DISPLAY_MODAL'; payload: boolean } | ||
| | { type: 'FETCH_INIT' } | ||
| | { type: 'FETCH_SUCCESS'; payload: boolean } | ||
| | { type: 'FETCH_FAILURE' } | ||
| | { type: 'RESET_IS_DELETED' }; | ||
|
|
||
| const dataFetchReducer = (state: DeleteState, action: Action): DeleteState => { | ||
| switch (action.type) { | ||
| case 'DISPLAY_MODAL': | ||
| return { | ||
| ...state, | ||
| isDisplayConfirmDeleteModal: action.payload, | ||
| }; | ||
| case 'FETCH_INIT': | ||
| return { | ||
| ...state, | ||
| isLoading: true, | ||
| isError: false, | ||
| }; | ||
| case 'FETCH_SUCCESS': | ||
| return { | ||
| ...state, | ||
| isLoading: false, | ||
| isError: false, | ||
| isDeleted: action.payload, | ||
| }; | ||
| case 'FETCH_FAILURE': | ||
| return { | ||
| ...state, | ||
| isLoading: false, | ||
| isError: true, | ||
| }; | ||
| case 'RESET_IS_DELETED': | ||
| return { | ||
| ...state, | ||
| isDeleted: false, | ||
| }; | ||
| default: | ||
| throw new Error(); | ||
stephmilovic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| }; | ||
| interface UseDeleteCase extends DeleteState { | ||
| dispatchResetIsDeleted: () => void; | ||
| handleOnDeleteConfirm: (caseIds: string[]) => void; | ||
| handleToggleModal: () => void; | ||
| } | ||
|
|
||
| export const useDeleteCases = (): UseDeleteCase => { | ||
|
There was a problem hiding this comment. What do you think about creating an AbortController, pass it to the API calls and abort in the return function? There was a problem hiding this comment. There was a problem hiding this comment. @XavierM thoughts? There was a problem hiding this comment. That's correct, I notice that too but I was thinking that we can change it to a specific PR later on and create an issue to track it. Therefore we can move forward to this PR and staying true to just do deletions and showing comments. I am saying that because that's not the only places we will have to change it and try to get better to avoid big PR. does that make sense? |
||
| const [state, dispatch] = useReducer(dataFetchReducer, { | ||
| isDisplayConfirmDeleteModal: false, | ||
| isLoading: false, | ||
| isError: false, | ||
| isDeleted: false, | ||
| }); | ||
| const [, dispatchToaster] = useStateToaster(); | ||
|
|
||
| const dispatchDeleteCases = useCallback(async (caseIds: string[]) => { | ||
| let cancel = false; | ||
| try { | ||
| dispatch({ type: 'FETCH_INIT' }); | ||
| await deleteCases(caseIds); | ||
| if (!cancel) { | ||
| dispatch({ type: 'FETCH_SUCCESS', payload: true }); | ||
| } | ||
| } catch (error) { | ||
| if (!cancel) { | ||
| errorToToaster({ | ||
| title: i18n.ERROR_TITLE, | ||
| error: error.body && error.body.message ? new Error(error.body.message) : error, | ||
| dispatchToaster, | ||
| }); | ||
| dispatch({ type: 'FETCH_FAILURE' }); | ||
| } | ||
| } | ||
| return () => { | ||
| cancel = true; | ||
| }; | ||
| }, []); | ||
|
|
||
| const dispatchToggleDeleteModal = useCallback(() => { | ||
| dispatch({ type: 'DISPLAY_MODAL', payload: !state.isDisplayConfirmDeleteModal }); | ||
| }, [state.isDisplayConfirmDeleteModal]); | ||
|
|
||
| const dispatchResetIsDeleted = useCallback(() => { | ||
| dispatch({ type: 'RESET_IS_DELETED' }); | ||
| }, [state.isDisplayConfirmDeleteModal]); | ||
|
|
||
| const handleOnDeleteConfirm = useCallback( | ||
| caseIds => { | ||
| dispatchDeleteCases(caseIds); | ||
stephmilovic marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dispatchToggleDeleteModal(); | ||
| }, | ||
| [state.isDisplayConfirmDeleteModal] | ||
| ); | ||
| const handleToggleModal = useCallback(() => { | ||
| dispatchToggleDeleteModal(); | ||
| }, [state.isDisplayConfirmDeleteModal]); | ||
|
|
||
| return { ...state, dispatchResetIsDeleted, handleOnDeleteConfirm, handleToggleModal }; | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about passing a signal (AbortController) so we can pass it to
fetch?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
related to this comment #59616 (comment)