Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix advanced wizard datafeed form labels #59413

Merged
merged 1 commit into from
Mar 5, 2020
Merged

[ML] Fix advanced wizard datafeed form labels #59413

merged 1 commit into from
Mar 5, 2020

Conversation

jgowdyelastic
Copy link
Member

Query was incorrectly labeled as scroll size and the default frequency was missing its units.

Before:
image

After:
image

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection cosmetic v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 5, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 5, 2020 12:55
@jgowdyelastic jgowdyelastic self-assigned this Mar 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do the translation files need rebuilding too?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit 4371b1c into elastic:master Mar 5, 2020
@jgowdyelastic jgowdyelastic deleted the fix-advanced-wizard-datafeed-form-labels branch March 5, 2020 15:00
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 5, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 5, 2020
@jgowdyelastic
[ML] Fix advanced wizard datafeed form labels (elastic#59413)
f7cda24
jgowdyelastic added a commit that referenced this pull request Mar 6, 2020
@jgowdyelastic @elasticmachine
[ML] Fix advanced wizard datafeed form labels (#59413) (#59431)
349b233 
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@jgowdyelastic jgowdyelastic

Labels
cosmetic Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson