[ML] Transforms: Fixed custom KibanaContext deprecation. #59410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
refactoring
v8.0.0
release_note:skip
walterra
requested review from
darnautov,
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This was referenced Mar 5, 2020
walterra
added a commit
that referenced
this pull request
Mar 6, 2020
…9421) - Deprecates the custom KibanaContext. - Where applicable dependencies provided via KibanaContext are now passed on via AppDependencies. - The main feature of KibanaContext was to populate index pattern and saved search information for the transform wizard. This is now provided via the useSearchItems() custom hook.
This was referenced Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed version of reverted PR #59133.
The code overall is the same as #59133, this just gets rid of some problematic jest snapshots and migrates the tests from enzyme to react-testing-library. So the only part that needs to be reviewed is in this commit: e5fea46
Checklist
For maintainers