[ML] Use Kibana's HttpHandler for HTTP requests #59320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
Feature:New Platform
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
78 tasks
darnautov
changed the title
jgowdyelastic
approved these changes
Mar 5, 2020
| export interface HttpOptions { | ||
| url?: string; | ||
| } | ||
| import { getHttp } from '../util/dependency_cache'; | ||
|
|
||
| function getResultHeaders(headers: HeadersInit): HeadersInit { | ||
| return { | ||
| asSystemRequest: false, |
There was a problem hiding this comment.
this should be true
Something that was missed in a previous PR, but worth updating now.
| import { from, Observable } from 'rxjs'; | ||
| import { switchMap } from 'rxjs/operators'; | ||
|
|
||
| import { getXSRF } from '../util/dependency_cache'; |
There was a problem hiding this comment.
getXSRF can now be removed from dependency_cache and all references to XSRF can go including the __LEGACY section from MlDependencies
# Conflicts: # x-pack/legacy/plugins/transform/public/plugin.ts # x-pack/legacy/plugins/transform/public/shim.ts
jgowdyelastic
approved these changes
Mar 5, 2020
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "before all" hook for "should return 403 for hiddentype doc"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "after all" hook for "should return 403 for hiddentype doc"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_only.x-pack/test/saved_object_api_integration/security_only/apis/bulk_update·ts.saved objects security only enabled bulkUpdate dual-privileges readonly user "before all" hook for "should return 403 for hiddentype doc"Standard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Mar 6, 2020
* [ML] use kibana http * [ML] fromHttpHandler * [ML] remove __LEGACY, update asSystemRequest header * [ML] transform with NP http
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 6, 2020
…x-closed-index * 'master' of github.com:elastic/kibana: (32 commits) [ML] Use Kibana's HttpHandler for HTTP requests (elastic#59320) [APM] Create settings page to manage Custom Links (elastic#57788) [Upgrade Assistant] Server-side batch reindexing (elastic#58598) completes navigation test (elastic#59141) [SIEM] Fixes dragging entries to the Timeline while data is loading may trigger a partial page reload (elastic#59476) [Reporting/Screenshots] Handle page setup errors and capture the page, don't fail the job (elastic#58683) [SIEM] [CASES] API with io-ts validation (elastic#59265) Use camelCase rather than snakeCase for plugin name (elastic#59461) [Maps] top term percentage field property (elastic#59386) Add custom action to registry and show actions list in siem (elastic#58395) [Search service] Add enhanced ES search strategy (elastic#59224) [Logs UI] Speed up stream rendering using memoization (elastic#59163) expand max-old-space-size for xpack jest tests (elastic#59455) Added possibility to embed connectors create and edit flyouts (elastic#58514) Revert "Temporarily disabling PR project mappings (elastic#59485)" (elastic#59491) Temporarily disabling PR project mappings (elastic#59485) [Endpoint] Fix alert list functional test error (elastic#59357) Rename status_page to statusPage (elastic#59186) Fix visual baseline job (elastic#59348) Extended AlertContextValue with metadata optional property (elastic#59391) ... # Conflicts: # x-pack/plugins/upgrade_assistant/common/types.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.test.ts # x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.test.ts # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
darnautov
added a commit
that referenced
this pull request
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #49743. Replaces
fetchin http service with Kibana HttpHandler. It prepends the URL with a base path and adds requiredkbn-headers to the request so ML API services have been adjusted accordingly. Alsohttp$required to introduce a customfromFetchto use kibana's http handler instead of build-in fetch.Checklist